Title: [201994] trunk/Source/WebCore
- Revision
- 201994
- Author
- [email protected]
- Date
- 2016-06-13 10:28:29 -0700 (Mon, 13 Jun 2016)
Log Message
Make sure HTTPHeaderMap gets a move constructor / assignment operator
https://bugs.webkit.org/show_bug.cgi?id=158695
<rdar://problem/26729511>
Reviewed by Alex Christensen.
Make sure HTTPHeaderMap gets a move constructor / assignment operator.
It was not getting an implicit one because of its user-declared
destructor. This patch drops the user-declared destructor so that
HTTPHeaderMap now gets an implicit move constructor / assignment
operator.
Not having a move constructor / assignment operator is an issue because
we rely on HTTPHeaderMap::isolatedCopy() / WTFMove() since r201623 to
pass HTTPHeaderMap across thread.
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::~HTTPHeaderMap): Deleted.
* platform/network/HTTPHeaderMap.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201993 => 201994)
--- trunk/Source/WebCore/ChangeLog 2016-06-13 16:52:37 UTC (rev 201993)
+++ trunk/Source/WebCore/ChangeLog 2016-06-13 17:28:29 UTC (rev 201994)
@@ -1,3 +1,25 @@
+2016-06-13 Chris Dumez <[email protected]>
+
+ Make sure HTTPHeaderMap gets a move constructor / assignment operator
+ https://bugs.webkit.org/show_bug.cgi?id=158695
+ <rdar://problem/26729511>
+
+ Reviewed by Alex Christensen.
+
+ Make sure HTTPHeaderMap gets a move constructor / assignment operator.
+ It was not getting an implicit one because of its user-declared
+ destructor. This patch drops the user-declared destructor so that
+ HTTPHeaderMap now gets an implicit move constructor / assignment
+ operator.
+
+ Not having a move constructor / assignment operator is an issue because
+ we rely on HTTPHeaderMap::isolatedCopy() / WTFMove() since r201623 to
+ pass HTTPHeaderMap across thread.
+
+ * platform/network/HTTPHeaderMap.cpp:
+ (WebCore::HTTPHeaderMap::~HTTPHeaderMap): Deleted.
+ * platform/network/HTTPHeaderMap.h:
+
2016-06-13 Nael Ouedraogo <[email protected]>
Remove useless parameter from GenerateParametersCheck signature
Modified: trunk/Source/WebCore/platform/network/HTTPHeaderMap.cpp (201993 => 201994)
--- trunk/Source/WebCore/platform/network/HTTPHeaderMap.cpp 2016-06-13 16:52:37 UTC (rev 201993)
+++ trunk/Source/WebCore/platform/network/HTTPHeaderMap.cpp 2016-06-13 17:28:29 UTC (rev 201994)
@@ -40,10 +40,6 @@
{
}
-HTTPHeaderMap::~HTTPHeaderMap()
-{
-}
-
HTTPHeaderMap HTTPHeaderMap::isolatedCopy() const
{
HTTPHeaderMap map;
Modified: trunk/Source/WebCore/platform/network/HTTPHeaderMap.h (201993 => 201994)
--- trunk/Source/WebCore/platform/network/HTTPHeaderMap.h 2016-06-13 16:52:37 UTC (rev 201993)
+++ trunk/Source/WebCore/platform/network/HTTPHeaderMap.h 2016-06-13 17:28:29 UTC (rev 201994)
@@ -115,7 +115,6 @@
typedef HTTPHeaderMapConstIterator const_iterator;
WEBCORE_EXPORT HTTPHeaderMap();
- WEBCORE_EXPORT ~HTTPHeaderMap();
// Gets a copy of the data suitable for passing to another thread.
HTTPHeaderMap isolatedCopy() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
