Title: [201995] trunk/Source/WebCore
- Revision
- 201995
- Author
- [email protected]
- Date
- 2016-06-13 10:32:50 -0700 (Mon, 13 Jun 2016)
Log Message
Modern IDB: IDBOpenDBRequest objects leak.
https://bugs.webkit.org/show_bug.cgi?id=158694
Reviewed by Alex Christensen.
No new tests (Currently have no testing strategy for guaranteeing lifetime of WebCore DOM objects)
* Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): At this point we never need the
request again, so remove it from the map.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (201994 => 201995)
--- trunk/Source/WebCore/ChangeLog 2016-06-13 17:28:29 UTC (rev 201994)
+++ trunk/Source/WebCore/ChangeLog 2016-06-13 17:32:50 UTC (rev 201995)
@@ -1,3 +1,16 @@
+2016-06-13 Brady Eidson <[email protected]>
+
+ Modern IDB: IDBOpenDBRequest objects leak.
+ https://bugs.webkit.org/show_bug.cgi?id=158694
+
+ Reviewed by Alex Christensen.
+
+ No new tests (Currently have no testing strategy for guaranteeing lifetime of WebCore DOM objects)
+
+ * Modules/indexeddb/client/IDBConnectionProxy.cpp:
+ (WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): At this point we never need the
+ request again, so remove it from the map.
+
2016-06-13 Chris Dumez <[email protected]>
Make sure HTTPHeaderMap gets a move constructor / assignment operator
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp (201994 => 201995)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp 2016-06-13 17:28:29 UTC (rev 201994)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp 2016-06-13 17:32:50 UTC (rev 201995)
@@ -107,7 +107,7 @@
RefPtr<IDBOpenDBRequest> request;
{
Locker<Lock> locker(m_openDBRequestMapLock);
- request = m_openDBRequestMap.get(resultData.requestIdentifier());
+ request = m_openDBRequestMap.take(resultData.requestIdentifier());
}
if (!request)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
