Title: [201996] trunk/PerformanceTests
- Revision
- 201996
- Author
- [email protected]
- Date
- 2016-06-13 11:08:36 -0700 (Mon, 13 Jun 2016)
Log Message
Fix round-down goof in Air.js's ShuffleCustom.forEachArg
https://bugs.webkit.org/show_bug.cgi?id=158674
Reviewed by Michael Saboff.
x / 3 * 3 is not how you round down to multiples of 3 in _javascript_. You need to do
Math.floor(x / 3) * 3 instead.
This is a benign change, because having extra arguments to a Shuffle is not something we
actually take advantage of yet. But I think it's best to match the original C++ code's
intent.
* Air.js/custom.js:
(const.ShuffleCustom.forEachArg):
Modified Paths
Diff
Modified: trunk/PerformanceTests/Air.js/custom.js (201995 => 201996)
--- trunk/PerformanceTests/Air.js/custom.js 2016-06-13 17:32:50 UTC (rev 201995)
+++ trunk/PerformanceTests/Air.js/custom.js 2016-06-13 18:08:36 UTC (rev 201996)
@@ -27,7 +27,7 @@
const ShuffleCustom = {
forEachArg(inst, func)
{
- var limit = inst.args.length / 3 * 3;
+ var limit = Math.floor(inst.args.length / 3) * 3;
for (let i = 0; i < limit; i += 3) {
let src = "" + 0];
let dst = inst.args[i + 1];
Modified: trunk/PerformanceTests/ChangeLog (201995 => 201996)
--- trunk/PerformanceTests/ChangeLog 2016-06-13 17:32:50 UTC (rev 201995)
+++ trunk/PerformanceTests/ChangeLog 2016-06-13 18:08:36 UTC (rev 201996)
@@ -1,3 +1,20 @@
+2016-06-12 Filip Pizlo <[email protected]>
+
+ Fix round-down goof in Air.js's ShuffleCustom.forEachArg
+ https://bugs.webkit.org/show_bug.cgi?id=158674
+
+ Reviewed by Michael Saboff.
+
+ x / 3 * 3 is not how you round down to multiples of 3 in _javascript_. You need to do
+ Math.floor(x / 3) * 3 instead.
+
+ This is a benign change, because having extra arguments to a Shuffle is not something we
+ actually take advantage of yet. But I think it's best to match the original C++ code's
+ intent.
+
+ * Air.js/custom.js:
+ (const.ShuffleCustom.forEachArg):
+
2016-06-11 Filip Pizlo <[email protected]>
Unreviewed, skip Air.js. It got unskipped when I renamed it from JSAir.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
