Title: [202017] trunk/Source/WebCore
- Revision
- 202017
- Author
- [email protected]
- Date
- 2016-06-13 17:11:16 -0700 (Mon, 13 Jun 2016)
Log Message
Drop HipChat hack introduced in r197548
https://bugs.webkit.org/show_bug.cgi?id=158711
Reviewed by Geoffrey Garen.
Drop HipChat hack introduced in r197548. This hack is no longer needed
as the bug was fixed in HipChat since then:
https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532
I have confirmed locally that the latest version (4.0.12.665) is able
to connect without the hack.
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::putDelegate): Deleted.
* platform/RuntimeApplicationChecks.h:
* platform/RuntimeApplicationChecks.mm:
(WebCore::MacApplication::isHipChat): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202016 => 202017)
--- trunk/Source/WebCore/ChangeLog 2016-06-13 23:52:09 UTC (rev 202016)
+++ trunk/Source/WebCore/ChangeLog 2016-06-14 00:11:16 UTC (rev 202017)
@@ -1,3 +1,23 @@
+2016-06-13 Chris Dumez <[email protected]>
+
+ Drop HipChat hack introduced in r197548
+ https://bugs.webkit.org/show_bug.cgi?id=158711
+
+ Reviewed by Geoffrey Garen.
+
+ Drop HipChat hack introduced in r197548. This hack is no longer needed
+ as the bug was fixed in HipChat since then:
+ https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532
+
+ I have confirmed locally that the latest version (4.0.12.665) is able
+ to connect without the hack.
+
+ * bindings/js/JSLocationCustom.cpp:
+ (WebCore::JSLocation::putDelegate): Deleted.
+ * platform/RuntimeApplicationChecks.h:
+ * platform/RuntimeApplicationChecks.mm:
+ (WebCore::MacApplication::isHipChat): Deleted.
+
2016-06-13 Chris Fleizach <[email protected]>
AX: CrashTracer: com.apple.WebKit.WebContent at WebCore::AccessibilityRenderObject::remoteSVGRootElement const + 227
Modified: trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp (202016 => 202017)
--- trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp 2016-06-13 23:52:09 UTC (rev 202016)
+++ trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp 2016-06-14 00:11:16 UTC (rev 202017)
@@ -86,12 +86,6 @@
if (propertyName != exec->propertyNames().href && !sameDomainAccess)
return true;
-#if PLATFORM(MAC)
- // FIXME: HipChat tries to set Location.reload which causes an exception to be thrown in strict mode (see <rdar://problem/24931959>).
- if (MacApplication::isHipChat())
- slot.setStrictMode(false);
-#endif
-
return false;
}
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (202016 => 202017)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-06-13 23:52:09 UTC (rev 202016)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-06-14 00:11:16 UTC (rev 202017)
@@ -51,7 +51,6 @@
bool isSolidStateNetworksDownloader();
WEBCORE_EXPORT bool isVersions();
WEBCORE_EXPORT bool isHRBlock();
-WEBCORE_EXPORT bool isHipChat();
} // MacApplication
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm (202016 => 202017)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-06-13 23:52:09 UTC (rev 202016)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-06-14 00:11:16 UTC (rev 202017)
@@ -154,12 +154,6 @@
return isSolidStateNetworksDownloader;
}
-bool MacApplication::isHipChat()
-{
- static bool isHipChat = applicationBundleIsEqualTo("com.hipchat.HipChat");
- return isHipChat;
-}
-
#endif // PLATFORM(MAC)
#if PLATFORM(IOS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
