Title: [202018] trunk/Source/WebCore
- Revision
- 202018
- Author
- [email protected]
- Date
- 2016-06-13 17:17:44 -0700 (Mon, 13 Jun 2016)
Log Message
REGRESSION(r201956): Failure to initialize new internal settings produced random test failures in release.
https://bugs.webkit.org/show_bug.cgi?id=158713
rdar://26769957
Reviewed by Simon Fraser.
Failed to initialize the new member variable in both Settings and InternalSettings classes.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202017 => 202018)
--- trunk/Source/WebCore/ChangeLog 2016-06-14 00:11:16 UTC (rev 202017)
+++ trunk/Source/WebCore/ChangeLog 2016-06-14 00:17:44 UTC (rev 202018)
@@ -1,3 +1,18 @@
+2016-06-13 Enrica Casucci <[email protected]>
+
+ REGRESSION(r201956): Failure to initialize new internal settings produced random test failures in release.
+ https://bugs.webkit.org/show_bug.cgi?id=158713
+ rdar://26769957
+
+ Reviewed by Simon Fraser.
+
+ Failed to initialize the new member variable in both Settings and InternalSettings classes.
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+
2016-06-13 Chris Dumez <[email protected]>
Drop HipChat hack introduced in r197548
Modified: trunk/Source/WebCore/page/Settings.cpp (202017 => 202018)
--- trunk/Source/WebCore/page/Settings.cpp 2016-06-14 00:11:16 UTC (rev 202017)
+++ trunk/Source/WebCore/page/Settings.cpp 2016-06-14 00:17:44 UTC (rev 202018)
@@ -192,6 +192,7 @@
, m_isJavaEnabledForLocalFiles(true)
, m_loadsImagesAutomatically(false)
, m_areImagesEnabled(true)
+ , m_preferMIMETypeForImages(false)
, m_arePluginsEnabled(false)
, m_isScriptEnabled(false)
, m_needsAdobeFrameReloadingQuirk(false)
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (202017 => 202018)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2016-06-14 00:11:16 UTC (rev 202017)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2016-06-14 00:17:44 UTC (rev 202018)
@@ -79,6 +79,7 @@
, m_originalMockScrollbarsEnabled(settings.mockScrollbarsEnabled())
, m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::sharedFeatures().langAttributeAwareFormControlUIEnabled())
, m_imagesEnabled(settings.areImagesEnabled())
+ , m_preferMIMETypeForImages(settings.preferMIMETypeForImages())
, m_minimumTimerInterval(settings.minimumDOMTimerInterval())
#if ENABLE(VIDEO_TRACK)
, m_shouldDisplaySubtitles(settings.shouldDisplaySubtitles())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
