Title: [202028] trunk/Source/WebCore
Revision
202028
Author
[email protected]
Date
2016-06-13 23:08:56 -0700 (Mon, 13 Jun 2016)

Log Message

Remove hasStaticPropertyTable (part 1: DOM bindings)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

* bindings/js/JSDOMBinding.h:
(WebCore::getStaticValueSlotEntryWithoutCaching): Deleted.
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>): Deleted.
    - this method is not used anywhere.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202027 => 202028)


--- trunk/Source/WebCore/ChangeLog	2016-06-14 06:04:32 UTC (rev 202027)
+++ trunk/Source/WebCore/ChangeLog	2016-06-14 06:08:56 UTC (rev 202028)
@@ -1,3 +1,17 @@
+2016-06-13  Gavin & Ellie Barraclough  <[email protected]>
+
+        Remove hasStaticPropertyTable (part 1: DOM bindings)
+        https://bugs.webkit.org/show_bug.cgi?id=158431
+
+        Reviewed by Chris Dumez.
+
+        All uses of hasStaticPropertyTable flag generated by bindings are wrong.
+
+        * bindings/js/JSDOMBinding.h:
+        (WebCore::getStaticValueSlotEntryWithoutCaching): Deleted.
+        (WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>): Deleted.
+            - this method is not used anywhere.
+
 2016-06-13  Adam Bergkvist  <[email protected]>
 
         WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()

Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (202027 => 202028)


--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2016-06-14 06:04:32 UTC (rev 202027)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2016-06-14 06:08:56 UTC (rev 202028)
@@ -304,7 +304,6 @@
 String propertyNameToString(JSC::PropertyName);
 AtomicString propertyNameToAtomicString(JSC::PropertyName);
 
-template<typename DOMClass> const JSC::HashTableValue* getStaticValueSlotEntryWithoutCaching(JSC::ExecState*, JSC::PropertyName);
 template<JSC::NativeFunction, int length> JSC::EncodedJSValue nonCachingStaticFunctionGetter(JSC::ExecState*, JSC::EncodedJSValue, JSC::PropertyName);
 
 // Inline functions and template definitions.
@@ -774,20 +773,6 @@
     return AtomicString(propertyName.uid() ? propertyName.uid() : propertyName.publicName());
 }
 
-template<typename DOMClass> inline const JSC::HashTableValue* getStaticValueSlotEntryWithoutCaching(JSC::ExecState* exec, JSC::PropertyName propertyName)
-{
-    if (DOMClass::hasStaticPropertyTable) {
-        if (auto* entry = DOMClass::info()->staticPropHashTable->entry(propertyName))
-            return entry;
-    }
-    return getStaticValueSlotEntryWithoutCaching<typename DOMClass::Base>(exec, propertyName);
-}
-
-template<> inline const JSC::HashTableValue* getStaticValueSlotEntryWithoutCaching<JSDOMObject>(JSC::ExecState*, JSC::PropertyName)
-{
-    return nullptr;
-}
-
 template<JSC::NativeFunction nativeFunction, int length> JSC::EncodedJSValue nonCachingStaticFunctionGetter(JSC::ExecState* exec, JSC::EncodedJSValue, JSC::PropertyName propertyName)
 {
     return JSC::JSValue::encode(JSC::JSFunction::create(exec->vm(), exec->lexicalGlobalObject(), length, propertyName.publicName(), nativeFunction));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to