Title: [202029] trunk/Source/WebCore
- Revision
- 202029
- Author
- [email protected]
- Date
- 2016-06-13 23:09:53 -0700 (Mon, 13 Jun 2016)
Log Message
Remove hasStaticPropertyTable (part 2: JSPluginElement)
https://bugs.webkit.org/show_bug.cgi?id=158431
Reviewed by Chris Dumez.
All uses of hasStaticPropertyTable flag generated by bindings are wrong.
The check in pluginElementCustomGetOwnPropertySlot was somewhat dubious in the
first place (for types with static properties it would give precedence to both
static and also property storage properties; for types without static properties
it would check neither - an odd asymetry in the case of values in the storage
array, and was depending on an implementation detail that could change).
This is all now redundant anyway. None of these types have static properties.
All properties are now corretcly on the prototype (which is handled appropriately
below). This is just dead code.
* bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- remove dead code.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202028 => 202029)
--- trunk/Source/WebCore/ChangeLog 2016-06-14 06:08:56 UTC (rev 202028)
+++ trunk/Source/WebCore/ChangeLog 2016-06-14 06:09:53 UTC (rev 202029)
@@ -1,5 +1,28 @@
2016-06-13 Gavin & Ellie Barraclough <[email protected]>
+ Remove hasStaticPropertyTable (part 2: JSPluginElement)
+ https://bugs.webkit.org/show_bug.cgi?id=158431
+
+ Reviewed by Chris Dumez.
+
+ All uses of hasStaticPropertyTable flag generated by bindings are wrong.
+
+ The check in pluginElementCustomGetOwnPropertySlot was somewhat dubious in the
+ first place (for types with static properties it would give precedence to both
+ static and also property storage properties; for types without static properties
+ it would check neither - an odd asymetry in the case of values in the storage
+ array, and was depending on an implementation detail that could change).
+
+ This is all now redundant anyway. None of these types have static properties.
+ All properties are now corretcly on the prototype (which is handled appropriately
+ below). This is just dead code.
+
+ * bindings/js/JSPluginElementFunctions.h:
+ (WebCore::pluginElementCustomGetOwnPropertySlot):
+ - remove dead code.
+
+2016-06-13 Gavin & Ellie Barraclough <[email protected]>
+
Remove hasStaticPropertyTable (part 1: DOM bindings)
https://bugs.webkit.org/show_bug.cgi?id=158431
Modified: trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h (202028 => 202029)
--- trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h 2016-06-14 06:08:56 UTC (rev 202028)
+++ trunk/Source/WebCore/bindings/js/JSPluginElementFunctions.h 2016-06-14 06:09:53 UTC (rev 202029)
@@ -46,14 +46,11 @@
template <class Type, class Base> bool pluginElementCustomGetOwnPropertySlot(JSC::ExecState* exec, JSC::PropertyName propertyName, JSC::PropertySlot& slot, Type* element)
{
if (!element->globalObject()->world().isNormal()) {
- if (Type::hasStaticPropertyTable && Type::getOwnPropertySlot(element, exec, propertyName, slot))
- return true;
-
JSC::JSValue proto = element->getPrototypeDirect();
if (proto.isObject() && JSC::jsCast<JSC::JSObject*>(asObject(proto))->hasProperty(exec, propertyName))
return false;
}
-
+
return pluginElementCustomGetOwnPropertySlot(exec, propertyName, slot, element);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
