Title: [202967] trunk
Revision
202967
Author
[email protected]
Date
2016-07-07 23:28:58 -0700 (Thu, 07 Jul 2016)

Log Message

[Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=159510

Reviewed by Brent Fulgham.

Source/WebCore:

On Windows, validate certificate chain even when any https certificate is allowed.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):

Tools:

Allow any https certificate when running tests.

* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202966 => 202967)


--- trunk/Source/WebCore/ChangeLog	2016-07-08 06:25:34 UTC (rev 202966)
+++ trunk/Source/WebCore/ChangeLog	2016-07-08 06:28:58 UTC (rev 202967)
@@ -1,3 +1,15 @@
+2016-07-07  Per Arne Vollan  <[email protected]>
+
+        [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
+        https://bugs.webkit.org/show_bug.cgi?id=159510
+
+        Reviewed by Brent Fulgham.
+
+        On Windows, validate certificate chain even when any https certificate is allowed.
+
+        * platform/network/cf/ResourceHandleCFNet.cpp:
+        (WebCore::ResourceHandle::createCFURLConnection):
+
 2016-07-07  Frederic Wang  <[email protected]>
 
         Bug 155792 - Basic implementation of mpadded

Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (202966 => 202967)


--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2016-07-08 06:25:34 UTC (rev 202966)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2016-07-08 06:28:58 UTC (rev 202967)
@@ -173,7 +173,9 @@
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsAnyRoot, kCFBooleanTrue);
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsExpiredRoots, kCFBooleanTrue);
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsExpiredCertificates, kCFBooleanTrue);
+#if !PLATFORM(WIN) // Remove platform #ifdef when <rdar://problem/26768077> is fixed.
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLValidatesCertificateChain, kCFBooleanFalse);
+#endif
     }
 
     auto clientCert = clientCertificates().find(firstRequest().url().host());

Modified: trunk/Tools/ChangeLog (202966 => 202967)


--- trunk/Tools/ChangeLog	2016-07-08 06:25:34 UTC (rev 202966)
+++ trunk/Tools/ChangeLog	2016-07-08 06:28:58 UTC (rev 202967)
@@ -1,3 +1,15 @@
+2016-07-07  Per Arne Vollan  <[email protected]>
+
+        [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
+        https://bugs.webkit.org/show_bug.cgi?id=159510
+
+        Reviewed by Brent Fulgham.
+
+        Allow any https certificate when running tests.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (runTest):
+
 2016-07-07  Beth Dakin  <[email protected]>
 
         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (202966 => 202967)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2016-07-08 06:25:34 UTC (rev 202966)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2016-07-08 06:28:58 UTC (rev 202967)
@@ -1138,6 +1138,7 @@
 
     request->initWithURL(urlBStr, WebURLRequestUseProtocolCachePolicy, 60);
     request->setHTTPMethod(methodBStr);
+    request->setAllowsAnyHTTPSCertificate();
     frame->loadRequest(request.get());
 
     while (true) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to