Title: [202968] trunk/Source/WebCore
Revision
202968
Author
[email protected]
Date
2016-07-07 23:32:41 -0700 (Thu, 07 Jul 2016)

Log Message

Clean up PassRefPtr in Modules/webaudio
https://bugs.webkit.org/show_bug.cgi?id=159540

Reviewed by Alex Christensen.

Purge PassRefPtr in webaudio directory.

No new tests, no behavior changes.

* Modules/webaudio/AsyncAudioDecoder.h:
* Modules/webaudio/AudioBasicProcessorNode.h:
* Modules/webaudio/AudioBuffer.h:
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioListener.h:
* Modules/webaudio/AudioParam.h:
* Modules/webaudio/AudioParamTimeline.h:
(WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
* Modules/webaudio/AudioProcessingEvent.cpp:
(WebCore::AudioProcessingEvent::AudioProcessingEvent):
* Modules/webaudio/AudioProcessingEvent.h:
(WebCore::AudioProcessingEvent::create):
* Modules/webaudio/ChannelMergerNode.h:
* Modules/webaudio/ChannelSplitterNode.h:
* Modules/webaudio/GainNode.h:
* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioDestinationNode.h:
* Modules/webaudio/MediaStreamAudioSource.cpp:
(WebCore::MediaStreamAudioSource::addAudioConsumer):
* Modules/webaudio/MediaStreamAudioSource.h:
* Modules/webaudio/OfflineAudioCompletionEvent.cpp:
(WebCore::OfflineAudioCompletionEvent::create):
(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
* Modules/webaudio/OfflineAudioCompletionEvent.h:
* Modules/webaudio/OfflineAudioDestinationNode.h:
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/PeriodicWave.h:
* Modules/webaudio/ScriptProcessorNode.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202967 => 202968)


--- trunk/Source/WebCore/ChangeLog	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/ChangeLog	2016-07-08 06:32:41 UTC (rev 202968)
@@ -1,3 +1,43 @@
+2016-07-07  Gyuyoung Kim  <[email protected]>
+
+        Clean up PassRefPtr in Modules/webaudio
+        https://bugs.webkit.org/show_bug.cgi?id=159540
+
+        Reviewed by Alex Christensen.
+
+        Purge PassRefPtr in webaudio directory.
+
+        No new tests, no behavior changes.
+
+        * Modules/webaudio/AsyncAudioDecoder.h:
+        * Modules/webaudio/AudioBasicProcessorNode.h:
+        * Modules/webaudio/AudioBuffer.h:
+        * Modules/webaudio/AudioBufferSourceNode.h:
+        * Modules/webaudio/AudioListener.h:
+        * Modules/webaudio/AudioParam.h:
+        * Modules/webaudio/AudioParamTimeline.h:
+        (WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
+        * Modules/webaudio/AudioProcessingEvent.cpp:
+        (WebCore::AudioProcessingEvent::AudioProcessingEvent):
+        * Modules/webaudio/AudioProcessingEvent.h:
+        (WebCore::AudioProcessingEvent::create):
+        * Modules/webaudio/ChannelMergerNode.h:
+        * Modules/webaudio/ChannelSplitterNode.h:
+        * Modules/webaudio/GainNode.h:
+        * Modules/webaudio/MediaElementAudioSourceNode.h:
+        * Modules/webaudio/MediaStreamAudioDestinationNode.h:
+        * Modules/webaudio/MediaStreamAudioSource.cpp:
+        (WebCore::MediaStreamAudioSource::addAudioConsumer):
+        * Modules/webaudio/MediaStreamAudioSource.h:
+        * Modules/webaudio/OfflineAudioCompletionEvent.cpp:
+        (WebCore::OfflineAudioCompletionEvent::create):
+        (WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
+        * Modules/webaudio/OfflineAudioCompletionEvent.h:
+        * Modules/webaudio/OfflineAudioDestinationNode.h:
+        * Modules/webaudio/OscillatorNode.h:
+        * Modules/webaudio/PeriodicWave.h:
+        * Modules/webaudio/ScriptProcessorNode.h:
+
 2016-07-07  Per Arne Vollan  <[email protected]>
 
         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.

Modified: trunk/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -28,7 +28,6 @@
 #include <memory>
 #include <wtf/Forward.h>
 #include <wtf/MessageQueue.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Threading.h>
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -27,7 +27,6 @@
 
 #include "AudioNode.h"
 #include <memory>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/Threading.h>
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -30,7 +30,6 @@
 #define AudioBuffer_h
 
 #include <runtime/Float32Array.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Vector.h>

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -33,7 +33,6 @@
 #include "PannerNode.h"
 #include <memory>
 #include <wtf/Lock.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 
 namespace WebCore {

Modified: trunk/Source/WebCore/Modules/webaudio/AudioListener.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioListener.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioListener.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -30,7 +30,7 @@
 #define AudioListener_h
 
 #include "FloatPoint3D.h"
-#include <wtf/PassRefPtr.h>
+#include <wtf/Ref.h>
 #include <wtf/RefCounted.h>
 
 namespace WebCore {

Modified: trunk/Source/WebCore/Modules/webaudio/AudioParam.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioParam.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParam.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -34,7 +34,6 @@
 #include "AudioSummingJunction.h"
 #include <runtime/Float32Array.h>
 #include <sys/types.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/text/WTFString.h>
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParamTimeline.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -32,7 +32,6 @@
 #include "AudioContext.h"
 #include <runtime/Float32Array.h>
 #include <wtf/Lock.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/Vector.h>
 
@@ -76,13 +75,13 @@
             LastType
         };
 
-        ParamEvent(Type type, float value, float time, float timeConstant, float duration, PassRefPtr<Float32Array> curve)
+        ParamEvent(Type type, float value, float time, float timeConstant, float duration, RefPtr<Float32Array>&& curve)
             : m_type(type)
             , m_value(value)
             , m_time(time)
             , m_timeConstant(timeConstant)
             , m_duration(duration)
-            , m_curve(curve)
+            , m_curve(WTFMove(curve))
         {
         }
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp	2016-07-08 06:32:41 UTC (rev 202968)
@@ -37,10 +37,10 @@
 {
 }
 
-AudioProcessingEvent::AudioProcessingEvent(PassRefPtr<AudioBuffer> inputBuffer, PassRefPtr<AudioBuffer> outputBuffer, double playbackTime)
+AudioProcessingEvent::AudioProcessingEvent(RefPtr<AudioBuffer>&& inputBuffer, RefPtr<AudioBuffer>&& outputBuffer, double playbackTime)
     : Event(eventNames().audioprocessEvent, true, false)
-    , m_inputBuffer(inputBuffer)
-    , m_outputBuffer(outputBuffer)
+    , m_inputBuffer(WTFMove(inputBuffer))
+    , m_outputBuffer(WTFMove(outputBuffer))
     , m_playbackTime(playbackTime)
 {
 }

Modified: trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -27,7 +27,6 @@
 
 #include "AudioBuffer.h"
 #include "Event.h"
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 
 namespace WebCore {
@@ -36,9 +35,9 @@
     
 class AudioProcessingEvent : public Event {
 public:
-    static Ref<AudioProcessingEvent> create(PassRefPtr<AudioBuffer> inputBuffer, PassRefPtr<AudioBuffer> outputBuffer, double playbackTime)
+    static Ref<AudioProcessingEvent> create(RefPtr<AudioBuffer>&& inputBuffer, RefPtr<AudioBuffer>&& outputBuffer, double playbackTime)
     {
-        return adoptRef(*new AudioProcessingEvent(inputBuffer, outputBuffer, playbackTime));
+        return adoptRef(*new AudioProcessingEvent(WTFMove(inputBuffer), WTFMove(outputBuffer), playbackTime));
     }
 
     static Ref<AudioProcessingEvent> createForBindings()
@@ -56,7 +55,7 @@
 
 private:
     AudioProcessingEvent();
-    AudioProcessingEvent(PassRefPtr<AudioBuffer> inputBuffer, PassRefPtr<AudioBuffer> outputBuffer, double playbackTime);
+    AudioProcessingEvent(RefPtr<AudioBuffer>&& inputBuffer, RefPtr<AudioBuffer>&& outputBuffer, double playbackTime);
 
     RefPtr<AudioBuffer> m_inputBuffer;
     RefPtr<AudioBuffer> m_outputBuffer;

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -30,7 +30,6 @@
 #define ChannelMergerNode_h
 
 #include "AudioNode.h"
-#include <wtf/PassRefPtr.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -26,7 +26,6 @@
 #define ChannelSplitterNode_h
 
 #include "AudioNode.h"
-#include <wtf/PassRefPtr.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/Modules/webaudio/GainNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/GainNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/GainNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -27,7 +27,6 @@
 
 #include "AudioNode.h"
 #include "AudioParam.h"
-#include <wtf/PassRefPtr.h>
 #include <wtf/Threading.h>
 
 namespace WebCore {

Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -33,7 +33,6 @@
 #include "MultiChannelResampler.h"
 #include <memory>
 #include <wtf/Lock.h>
-#include <wtf/PassRefPtr.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -30,7 +30,6 @@
 #include "AudioBasicInspectorNode.h"
 #include "AudioBus.h"
 #include "MediaStream.h"
-#include <wtf/PassRefPtr.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.cpp (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.cpp	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.cpp	2016-07-08 06:32:41 UTC (rev 202968)
@@ -67,7 +67,7 @@
     return nullptr;
 }
 
-void MediaStreamAudioSource::addAudioConsumer(PassRefPtr<AudioDestinationConsumer> consumer)
+void MediaStreamAudioSource::addAudioConsumer(AudioDestinationConsumer* consumer)
 {
     LockHolder locker(m_audioConsumersLock);
     m_audioConsumers.append(consumer);

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -56,7 +56,7 @@
     void setAudioFormat(size_t numberOfChannels, float sampleRate);
     void consumeAudio(AudioBus*, size_t numberOfFrames);
 
-    void addAudioConsumer(PassRefPtr<AudioDestinationConsumer>);
+    void addAudioConsumer(AudioDestinationConsumer*);
     bool removeAudioConsumer(AudioDestinationConsumer*);
     const Vector<RefPtr<AudioDestinationConsumer>>& audioConsumers() const { return m_audioConsumers; }
 

Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp	2016-07-08 06:32:41 UTC (rev 202968)
@@ -33,14 +33,14 @@
 
 namespace WebCore {
 
-Ref<OfflineAudioCompletionEvent> OfflineAudioCompletionEvent::create(PassRefPtr<AudioBuffer> renderedBuffer)
+Ref<OfflineAudioCompletionEvent> OfflineAudioCompletionEvent::create(RefPtr<AudioBuffer>&& renderedBuffer)
 {
-    return adoptRef(*new OfflineAudioCompletionEvent(renderedBuffer));
+    return adoptRef(*new OfflineAudioCompletionEvent(WTFMove(renderedBuffer)));
 }
 
-OfflineAudioCompletionEvent::OfflineAudioCompletionEvent(PassRefPtr<AudioBuffer> renderedBuffer)
+OfflineAudioCompletionEvent::OfflineAudioCompletionEvent(RefPtr<AudioBuffer>&& renderedBuffer)
     : Event(eventNames().completeEvent, true, false)
-    , m_renderedBuffer(renderedBuffer)
+    , m_renderedBuffer(WTFMove(renderedBuffer))
 {
 }
 

Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -27,7 +27,6 @@
 
 #include "AudioBuffer.h"
 #include "Event.h"
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 
 namespace WebCore {
@@ -36,7 +35,7 @@
     
 class OfflineAudioCompletionEvent : public Event {
 public:
-    static Ref<OfflineAudioCompletionEvent> create(PassRefPtr<AudioBuffer> renderedBuffer);
+    static Ref<OfflineAudioCompletionEvent> create(RefPtr<AudioBuffer>&& renderedBuffer);
     
     virtual ~OfflineAudioCompletionEvent();
 
@@ -45,7 +44,7 @@
     EventInterface eventInterface() const override;
 
 private:
-    explicit OfflineAudioCompletionEvent(PassRefPtr<AudioBuffer> renderedBuffer);
+    explicit OfflineAudioCompletionEvent(RefPtr<AudioBuffer>&& renderedBuffer);
 
     RefPtr<AudioBuffer> m_renderedBuffer;
 };

Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -27,7 +27,6 @@
 
 #include "AudioBuffer.h"
 #include "AudioDestinationNode.h"
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Threading.h>
 

Modified: trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -29,7 +29,6 @@
 #include "AudioParam.h"
 #include "AudioScheduledSourceNode.h"
 #include <wtf/Lock.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 
 namespace WebCore {

Modified: trunk/Source/WebCore/Modules/webaudio/PeriodicWave.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/PeriodicWave.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/PeriodicWave.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -32,7 +32,6 @@
 #include "AudioArray.h"
 #include <memory>
 #include <runtime/Float32Array.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Vector.h>

Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h (202967 => 202968)


--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h	2016-07-08 06:28:58 UTC (rev 202967)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h	2016-07-08 06:32:41 UTC (rev 202968)
@@ -31,7 +31,6 @@
 #include "EventListener.h"
 #include "EventTarget.h"
 #include <wtf/Forward.h>
-#include <wtf/PassRefPtr.h>
 #include <wtf/RefPtr.h>
 #include <wtf/Vector.h>
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to