Title: [204371] trunk/LayoutTests
Revision
204371
Author
[email protected]
Date
2016-08-11 03:22:06 -0700 (Thu, 11 Aug 2016)

Log Message

Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=160689
<rdar://problem/24025664>

Patch by Antoine Quint <[email protected]> on 2016-08-11
Reviewed by Dean Jackson.

When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.

LayoutTests/imported/w3c:

* canvas/2d.gradient.interpolate.colouralpha.html:

LayoutTests:

* canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (204370 => 204371)


--- trunk/LayoutTests/ChangeLog	2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/ChangeLog	2016-08-11 10:22:06 UTC (rev 204371)
@@ -1,3 +1,18 @@
+2016-08-11  Antoine Quint  <[email protected]>
+
+        Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=160689
+        <rdar://problem/24025664>
+
+        Reviewed by Dean Jackson.
+
+        When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
+        However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
+        which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
+        interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
+
+        * canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:
+
 2016-08-10  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Should be able to Edit Node Attributes and Styles for non-UserAgent Shadow DOM nodes

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html (204370 => 204371)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html	2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html	2016-08-11 10:22:06 UTC (rev 204371)
@@ -17,9 +17,9 @@
 g.addColorStop(1, 'rgba(0,0,255, 1)');
 ctx.fillStyle = g;
 ctx.fillRect(0, 0, 100, 50);
-_assertPixelApprox(canvas, 25,25, 191,191,63,63, "25,25", "191,191,63,63", 3);
-_assertPixelApprox(canvas, 50,25, 127,127,127,127, "50,25", "127,127,127,127", 3);
-_assertPixelApprox(canvas, 75,25, 63,63,191,191, "75,25", "63,63,191,191", 3);
+_assertPixelApprox(canvas, 25,25, 190,190,65,65, "25,25", "190,190,65,65", 3);
+_assertPixelApprox(canvas, 50,25, 126,126,128,128, "50,25", "126,126,128,128", 3);
+_assertPixelApprox(canvas, 75,25, 62,62,192,192, "75,25", "62,62,192,192", 3);
 
 
 });

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204370 => 204371)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-11 10:22:06 UTC (rev 204371)
@@ -1,3 +1,18 @@
+2016-08-11  Antoine Quint  <[email protected]>
+
+        Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=160689
+        <rdar://problem/24025664>
+
+        Reviewed by Dean Jackson.
+
+        When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
+        However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
+        which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
+        interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
+
+        * canvas/2d.gradient.interpolate.colouralpha.html:
+
 2016-08-10  Chris Dumez  <[email protected]>
 
         Pull in recent upstream web-platform-tests changes for dom/ and html/

Modified: trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html (204370 => 204371)


--- trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html	2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html	2016-08-11 10:22:06 UTC (rev 204371)
@@ -26,9 +26,9 @@
 g.addColorStop(1, 'rgba(0,0,255, 1)');
 ctx.fillStyle = g;
 ctx.fillRect(0, 0, 100, 50);
-_assertPixelApprox(canvas, 25,25, 191,191,63,63, "25,25", "191,191,63,63", 3);
-_assertPixelApprox(canvas, 50,25, 127,127,127,127, "50,25", "127,127,127,127", 3);
-_assertPixelApprox(canvas, 75,25, 63,63,191,191, "75,25", "63,63,191,191", 3);
+_assertPixelApprox(canvas, 25,25, 190,190,65,65, "25,25", "190,190,65,65", 3);
+_assertPixelApprox(canvas, 50,25, 126,126,128,128, "50,25", "126,126,128,128", 3);
+_assertPixelApprox(canvas, 75,25, 62,62,192,192, "75,25", "62,62,192,192", 3);
 
 
 });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to