Title: [204450] trunk
Revision
204450
Author
[email protected]
Date
2016-08-13 15:37:18 -0700 (Sat, 13 Aug 2016)

Log Message

Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
https://bugs.webkit.org/show_bug.cgi?id=160829

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
to match the latest specification:
- https://html.spec.whatwg.org/multipage/dom.html#the-document-object

This also matches Chrome.

No new tests, rebaselined existing test.

* dom/Document.idl:
* html/HTMLDocument.idl:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204449 => 204450)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-13 22:36:20 UTC (rev 204449)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-08-13 22:37:18 UTC (rev 204450)
@@ -1,5 +1,16 @@
 2016-08-13  Chris Dumez  <[email protected]>
 
+        Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
+        https://bugs.webkit.org/show_bug.cgi?id=160829
+
+        Reviewed by Sam Weinig.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-08-13  Chris Dumez  <[email protected]>
+
         Move designMode attribute from HTMLDocument to Document
         https://bugs.webkit.org/show_bug.cgi?id=160838
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (204449 => 204450)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-08-13 22:36:20 UTC (rev 204449)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-08-13 22:37:18 UTC (rev 204450)
@@ -23,11 +23,11 @@
 PASS Document interface: attribute body 
 PASS Document interface: attribute head 
 PASS Document interface: attribute images 
-FAIL Document interface: attribute embeds assert_true: The prototype object must have a property "embeds" expected true got false
-FAIL Document interface: attribute plugins assert_true: The prototype object must have a property "plugins" expected true got false
+PASS Document interface: attribute embeds 
+PASS Document interface: attribute plugins 
 PASS Document interface: attribute links 
 PASS Document interface: attribute forms 
-FAIL Document interface: attribute scripts assert_true: The prototype object must have a property "scripts" expected true got false
+PASS Document interface: attribute scripts 
 PASS Document interface: operation getElementsByName(DOMString) 
 FAIL Document interface: attribute cssElementMap assert_true: The prototype object must have a property "cssElementMap" expected true got false
 PASS Document interface: attribute currentScript 
@@ -436,11 +436,11 @@
 PASS Document interface: new Document() must inherit property "body" with the proper type (43) 
 PASS Document interface: new Document() must inherit property "head" with the proper type (44) 
 PASS Document interface: new Document() must inherit property "images" with the proper type (45) 
-FAIL Document interface: new Document() must inherit property "embeds" with the proper type (46) assert_inherits: property "embeds" not found in prototype chain
-FAIL Document interface: new Document() must inherit property "plugins" with the proper type (47) assert_inherits: property "plugins" not found in prototype chain
+PASS Document interface: new Document() must inherit property "embeds" with the proper type (46) 
+PASS Document interface: new Document() must inherit property "plugins" with the proper type (47) 
 PASS Document interface: new Document() must inherit property "links" with the proper type (48) 
 PASS Document interface: new Document() must inherit property "forms" with the proper type (49) 
-FAIL Document interface: new Document() must inherit property "scripts" with the proper type (50) assert_inherits: property "scripts" not found in prototype chain
+PASS Document interface: new Document() must inherit property "scripts" with the proper type (50) 
 PASS Document interface: new Document() must inherit property "getElementsByName" with the proper type (51) 
 PASS Document interface: calling getElementsByName(DOMString) on new Document() with too few arguments must throw TypeError 
 FAIL Document interface: new Document() must inherit property "cssElementMap" with the proper type (52) assert_inherits: property "cssElementMap" not found in prototype chain
@@ -691,11 +691,11 @@
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "body" with the proper type (43) 
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "head" with the proper type (44) 
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "images" with the proper type (45) 
-FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "embeds" with the proper type (46) assert_inherits: property "embeds" not found in prototype chain
-FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "plugins" with the proper type (47) assert_inherits: property "plugins" not found in prototype chain
+PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "embeds" with the proper type (46) 
+PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "plugins" with the proper type (47) 
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "links" with the proper type (48) 
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "forms" with the proper type (49) 
-FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "scripts" with the proper type (50) assert_inherits: property "scripts" not found in prototype chain
+PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "scripts" with the proper type (50) 
 PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "getElementsByName" with the proper type (51) 
 PASS Document interface: calling getElementsByName(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError 
 FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "cssElementMap" with the proper type (52) assert_inherits: property "cssElementMap" not found in prototype chain

Modified: trunk/Source/WebCore/ChangeLog (204449 => 204450)


--- trunk/Source/WebCore/ChangeLog	2016-08-13 22:36:20 UTC (rev 204449)
+++ trunk/Source/WebCore/ChangeLog	2016-08-13 22:37:18 UTC (rev 204450)
@@ -1,5 +1,23 @@
 2016-08-13  Chris Dumez  <[email protected]>
 
+        Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
+        https://bugs.webkit.org/show_bug.cgi?id=160829
+
+        Reviewed by Sam Weinig.
+
+        Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
+        to match the latest specification:
+        - https://html.spec.whatwg.org/multipage/dom.html#the-document-object
+
+        This also matches Chrome.
+
+        No new tests, rebaselined existing test.
+
+        * dom/Document.idl:
+        * html/HTMLDocument.idl:
+
+2016-08-13  Chris Dumez  <[email protected]>
+
         Move designMode attribute from HTMLDocument to Document
         https://bugs.webkit.org/show_bug.cgi?id=160838
 

Modified: trunk/Source/WebCore/dom/Document.idl (204449 => 204450)


--- trunk/Source/WebCore/dom/Document.idl	2016-08-13 22:36:20 UTC (rev 204449)
+++ trunk/Source/WebCore/dom/Document.idl	2016-08-13 22:37:18 UTC (rev 204450)
@@ -161,6 +161,9 @@
     readonly attribute HTMLCollection links;
     readonly attribute HTMLCollection forms;
     readonly attribute HTMLCollection anchors;
+    readonly attribute HTMLCollection embeds;
+    readonly attribute HTMLCollection plugins;
+    readonly attribute HTMLCollection scripts;
     readonly attribute DOMString lastModified;
 
     NodeList getElementsByName([AtomicString] DOMString elementName);

Modified: trunk/Source/WebCore/html/HTMLDocument.idl (204449 => 204450)


--- trunk/Source/WebCore/html/HTMLDocument.idl	2016-08-13 22:36:20 UTC (rev 204449)
+++ trunk/Source/WebCore/html/HTMLDocument.idl	2016-08-13 22:37:18 UTC (rev 204450)
@@ -30,10 +30,6 @@
     [Custom] void write(optional DOMString text);
     [Custom] void writeln(optional DOMString text);
 
-    readonly attribute HTMLCollection embeds;
-    readonly attribute HTMLCollection plugins;
-    readonly attribute HTMLCollection scripts;
-
     // Extensions
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to