Title: [204451] trunk
- Revision
- 204451
- Author
- [email protected]
- Date
- 2016-08-13 17:10:22 -0700 (Sat, 13 Aug 2016)
Log Message
'compatMode' property should be on Document, not HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=160819
Reviewed by Sam Weinig.
Source/WebCore:
'compatMode' property should be on Document, not HTMLDocument:
- https://dom.spec.whatwg.org/#dom-document-compatmode
WebKit had it on both. Firefox and Chrome have it on Document only.
Test: fast/dom/Document/compatMode-location.html
* html/HTMLDocument.idl:
LayoutTests:
Add layout test coverage.
* fast/dom/Document/compatMode-location-expected.txt: Added.
* fast/dom/Document/compatMode-location.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (204450 => 204451)
--- trunk/LayoutTests/ChangeLog 2016-08-13 22:37:18 UTC (rev 204450)
+++ trunk/LayoutTests/ChangeLog 2016-08-14 00:10:22 UTC (rev 204451)
@@ -1,3 +1,15 @@
+2016-08-13 Chris Dumez <[email protected]>
+
+ 'compatMode' property should be on Document, not HTMLDocument
+ https://bugs.webkit.org/show_bug.cgi?id=160819
+
+ Reviewed by Sam Weinig.
+
+ Add layout test coverage.
+
+ * fast/dom/Document/compatMode-location-expected.txt: Added.
+ * fast/dom/Document/compatMode-location.html: Added.
+
2016-08-12 Chris Dumez <[email protected]>
getElementsByTagName() should take a qualifiedName in parameter
Added: trunk/LayoutTests/fast/dom/Document/compatMode-location-expected.txt (0 => 204451)
--- trunk/LayoutTests/fast/dom/Document/compatMode-location-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/compatMode-location-expected.txt 2016-08-14 00:10:22 UTC (rev 204451)
@@ -0,0 +1,11 @@
+Tests that the compatMode property getter is on Document and not HTMLDocument
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Object.getOwnPropertyDescriptor(HTMLDocument.prototype, 'compatMode') is undefined.
+PASS Object.getOwnPropertyDescriptor(Document.prototype, 'compatMode').get is an instance of Function
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/Document/compatMode-location.html (0 => 204451)
--- trunk/LayoutTests/fast/dom/Document/compatMode-location.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/compatMode-location.html 2016-08-14 00:10:22 UTC (rev 204451)
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Tests that the compatMode property getter is on Document and not HTMLDocument");
+
+shouldBeUndefined("Object.getOwnPropertyDescriptor(HTMLDocument.prototype, 'compatMode')");
+shouldBeType("Object.getOwnPropertyDescriptor(Document.prototype, 'compatMode').get", "Function");
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (204450 => 204451)
--- trunk/Source/WebCore/ChangeLog 2016-08-13 22:37:18 UTC (rev 204450)
+++ trunk/Source/WebCore/ChangeLog 2016-08-14 00:10:22 UTC (rev 204451)
@@ -1,5 +1,21 @@
2016-08-13 Chris Dumez <[email protected]>
+ 'compatMode' property should be on Document, not HTMLDocument
+ https://bugs.webkit.org/show_bug.cgi?id=160819
+
+ Reviewed by Sam Weinig.
+
+ 'compatMode' property should be on Document, not HTMLDocument:
+ - https://dom.spec.whatwg.org/#dom-document-compatmode
+
+ WebKit had it on both. Firefox and Chrome have it on Document only.
+
+ Test: fast/dom/Document/compatMode-location.html
+
+ * html/HTMLDocument.idl:
+
+2016-08-13 Chris Dumez <[email protected]>
+
Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
https://bugs.webkit.org/show_bug.cgi?id=160829
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (204450 => 204451)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2016-08-13 22:37:18 UTC (rev 204450)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2016-08-14 00:10:22 UTC (rev 204451)
@@ -48,8 +48,6 @@
attribute DOMString dir;
#endif
- readonly attribute DOMString compatMode;
-
// Deprecated attributes.
[TreatNullAs=EmptyString] attribute DOMString bgColor;
[TreatNullAs=EmptyString] attribute DOMString fgColor;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
