Title: [205377] trunk/Source/WebKit2
- Revision
- 205377
- Author
- [email protected]
- Date
- 2016-09-02 15:42:32 -0700 (Fri, 02 Sep 2016)
Log Message
[Mac] RetainPtr misuse, DDActionContext leaks
https://bugs.webkit.org/show_bug.cgi?id=161551
Patch by Joseph Pecoraro <[email protected]> on 2016-09-02
Reviewed by Tim Horton.
* Platform/mac/MenuUtilities.mm:
(WebKit::menuItemForTelephoneNumber):
(WebKit::menuForTelephoneNumber):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (205376 => 205377)
--- trunk/Source/WebKit2/ChangeLog 2016-09-02 22:29:17 UTC (rev 205376)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-02 22:42:32 UTC (rev 205377)
@@ -1,5 +1,16 @@
2016-09-02 Joseph Pecoraro <[email protected]>
+ [Mac] RetainPtr misuse, DDActionContext leaks
+ https://bugs.webkit.org/show_bug.cgi?id=161551
+
+ Reviewed by Tim Horton.
+
+ * Platform/mac/MenuUtilities.mm:
+ (WebKit::menuItemForTelephoneNumber):
+ (WebKit::menuForTelephoneNumber):
+
+2016-09-02 Joseph Pecoraro <[email protected]>
+
Fix Mac CMake build, missing _WKRemoteWebInspectorViewController.mm
Unreviewed build fix.
Modified: trunk/Source/WebKit2/Platform/mac/MenuUtilities.mm (205376 => 205377)
--- trunk/Source/WebKit2/Platform/mac/MenuUtilities.mm 2016-09-02 22:29:17 UTC (rev 205376)
+++ trunk/Source/WebKit2/Platform/mac/MenuUtilities.mm 2016-09-02 22:42:32 UTC (rev 205377)
@@ -53,7 +53,7 @@
if (!DataDetectorsLibrary())
return nil;
- RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
+ RetainPtr<DDActionContext> actionContext = adoptNS([[getDDActionContextClass() alloc] init]);
[actionContext setAllowedActionUTIs:@[ @"com.apple.dial" ]];
NSArray *proposedMenuItems = [[getDDActionsManagerClass() sharedManager] menuItemsForValue:(NSString *)telephoneNumber type:getDDBinderPhoneNumberKey() service:nil context:actionContext.get()];
@@ -84,7 +84,7 @@
NSMutableArray *faceTimeItems = [NSMutableArray array];
NSMenuItem *dialItem = nil;
- RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
+ RetainPtr<DDActionContext> actionContext = adoptNS([[getDDActionContextClass() alloc] init]);
[actionContext setAllowedActionUTIs:@[ @"com.apple.dial", @"com.apple.facetime", @"com.apple.facetimeaudio" ]];
NSArray *proposedMenuItems = [[getDDActionsManagerClass() sharedManager] menuItemsForValue:(NSString *)telephoneNumber type:getDDBinderPhoneNumberKey() service:nil context:actionContext.get()];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
