Title: [205378] trunk/Source
- Revision
- 205378
- Author
- [email protected]
- Date
- 2016-09-02 15:44:15 -0700 (Fri, 02 Sep 2016)
Log Message
[Mac] RetainPtr misuse, AnimationController leaks
https://bugs.webkit.org/show_bug.cgi?id=161552
Patch by Joseph Pecoraro <[email protected]> on 2016-09-02
Reviewed by Tim Horton.
Source/WebKit/mac:
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
Source/WebKit2:
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _defaultAnimationController]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (205377 => 205378)
--- trunk/Source/WebKit/mac/ChangeLog 2016-09-02 22:42:32 UTC (rev 205377)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-09-02 22:44:15 UTC (rev 205378)
@@ -1,3 +1,13 @@
+2016-09-02 Joseph Pecoraro <[email protected]>
+
+ [Mac] RetainPtr misuse, AnimationController leaks
+ https://bugs.webkit.org/show_bug.cgi?id=161552
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebImmediateActionController.mm:
+ (-[WebImmediateActionController _defaultAnimationController]):
+
2016-07-08 Jer Noble <[email protected]>
Refactor WebPlaybackSessionModelMediaElement to be client based.
Modified: trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm (205377 => 205378)
--- trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-09-02 22:42:32 UTC (rev 205377)
+++ trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm 2016-09-02 22:44:15 UTC (rev 205378)
@@ -63,8 +63,7 @@
@interface WebImmediateActionController () <QLPreviewMenuItemDelegate>
@end
-@interface WebAnimationController : NSObject <NSImmediateActionAnimationController> {
-}
+@interface WebAnimationController : NSObject <NSImmediateActionAnimationController>
@end
@implementation WebAnimationController
@@ -257,8 +256,8 @@
- (id <NSImmediateActionAnimationController>)_defaultAnimationController
{
if (_contentPreventsDefault) {
- RetainPtr<WebAnimationController> dummyController = [[WebAnimationController alloc] init];
- return dummyController.get();
+ RetainPtr<WebAnimationController> dummyController = adoptNS([[WebAnimationController alloc] init]);
+ return dummyController.autorelease();
}
NSURL *url = ""
Modified: trunk/Source/WebKit2/ChangeLog (205377 => 205378)
--- trunk/Source/WebKit2/ChangeLog 2016-09-02 22:42:32 UTC (rev 205377)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-02 22:44:15 UTC (rev 205378)
@@ -1,5 +1,15 @@
2016-09-02 Joseph Pecoraro <[email protected]>
+ [Mac] RetainPtr misuse, AnimationController leaks
+ https://bugs.webkit.org/show_bug.cgi?id=161552
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/mac/WKImmediateActionController.mm:
+ (-[WKImmediateActionController _defaultAnimationController]):
+
+2016-09-02 Joseph Pecoraro <[email protected]>
+
[Mac] RetainPtr misuse, DDActionContext leaks
https://bugs.webkit.org/show_bug.cgi?id=161551
Modified: trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm (205377 => 205378)
--- trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2016-09-02 22:42:32 UTC (rev 205377)
+++ trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm 2016-09-02 22:44:15 UTC (rev 205378)
@@ -55,8 +55,7 @@
@interface WKImmediateActionController () <QLPreviewMenuItemDelegate>
@end
-@interface WKAnimationController : NSObject <NSImmediateActionAnimationController> {
-}
+@interface WKAnimationController : NSObject <NSImmediateActionAnimationController>
@end
@implementation WKAnimationController
@@ -271,8 +270,8 @@
- (id <NSImmediateActionAnimationController>)_defaultAnimationController
{
if (_contentPreventsDefault) {
- RetainPtr<WKAnimationController> dummyController = [[WKAnimationController alloc] init];
- return dummyController.get();
+ RetainPtr<WKAnimationController> dummyController = adoptNS([[WKAnimationController alloc] init]);
+ return dummyController.autorelease();
}
RefPtr<API::HitTestResult> hitTestResult = [self _webHitTestResult];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
