Diff
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (205689 => 205690)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
@@ -148,7 +148,6 @@
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.align]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.archive]
TEST SUCCEEDED: The value was the empty string. [tested HTMLObjectElement.border]
-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeBase]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeType]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.height]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.name]
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (205689 => 205690)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-09-09 03:31:58 UTC (rev 205690)
@@ -384,7 +384,6 @@
{name: 'align', expectedNull: 'null'},
{name: 'archive', expectedNull: 'null'},
{name: 'border', expectedNull: ''},
- {name: 'codeBase', expectedNull: 'null'},
{name: 'codeType', expectedNull: 'null'},
{name: 'height', expectedNull: 'null'},
{name: 'name', expectedNull: 'null'},
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205689 => 205690)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-09 03:31:58 UTC (rev 205690)
@@ -1,5 +1,16 @@
2016-09-08 Chris Dumez <[email protected]>
+ HTMLObjectElement.codebase attribute should reflect as a URL
+ https://bugs.webkit.org/show_bug.cgi?id=161768
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline existing test now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-embedded-expected.txt:
+
+2016-09-08 Chris Dumez <[email protected]>
+
ol.start may return incorrect value for reversed lists when not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=161713
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205689 => 205690)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
@@ -6337,95 +6337,95 @@
PASS object.codeBase: typeof IDL attribute
PASS object.codeBase: IDL get with DOM attribute unset
PASS object.codeBase: setAttribute() to "" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
+PASS object.codeBase: setAttribute() to "" followed by IDL get
PASS object.codeBase: setAttribute() to " foo " followed by getAttribute()
-FAIL object.codeBase: setAttribute() to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
+PASS object.codeBase: setAttribute() to " foo " followed by IDL get
PASS object.codeBase: setAttribute() to "http://site.example/" followed by getAttribute()
PASS object.codeBase: setAttribute() to "http://site.example/" followed by IDL get
PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
+PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get
PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
+PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
PASS object.codeBase: setAttribute() to undefined followed by getAttribute()
-FAIL object.codeBase: setAttribute() to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
+PASS object.codeBase: setAttribute() to undefined followed by IDL get
PASS object.codeBase: setAttribute() to 7 followed by getAttribute()
-FAIL object.codeBase: setAttribute() to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
+PASS object.codeBase: setAttribute() to 7 followed by IDL get
PASS object.codeBase: setAttribute() to 1.5 followed by getAttribute()
-FAIL object.codeBase: setAttribute() to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
+PASS object.codeBase: setAttribute() to 1.5 followed by IDL get
PASS object.codeBase: setAttribute() to true followed by getAttribute()
-FAIL object.codeBase: setAttribute() to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
+PASS object.codeBase: setAttribute() to true followed by IDL get
PASS object.codeBase: setAttribute() to false followed by getAttribute()
-FAIL object.codeBase: setAttribute() to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
+PASS object.codeBase: setAttribute() to false followed by IDL get
PASS object.codeBase: setAttribute() to object "[object Object]" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
+PASS object.codeBase: setAttribute() to object "[object Object]" followed by IDL get
PASS object.codeBase: setAttribute() to NaN followed by getAttribute()
-FAIL object.codeBase: setAttribute() to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
+PASS object.codeBase: setAttribute() to NaN followed by IDL get
PASS object.codeBase: setAttribute() to Infinity followed by getAttribute()
-FAIL object.codeBase: setAttribute() to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
+PASS object.codeBase: setAttribute() to Infinity followed by IDL get
PASS object.codeBase: setAttribute() to -Infinity followed by getAttribute()
-FAIL object.codeBase: setAttribute() to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
+PASS object.codeBase: setAttribute() to -Infinity followed by IDL get
PASS object.codeBase: setAttribute() to "\0" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
+PASS object.codeBase: setAttribute() to "\0" followed by IDL get
PASS object.codeBase: setAttribute() to null followed by getAttribute()
-FAIL object.codeBase: setAttribute() to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
+PASS object.codeBase: setAttribute() to null followed by IDL get
PASS object.codeBase: setAttribute() to object "test-toString" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
+PASS object.codeBase: setAttribute() to object "test-toString" followed by IDL get
PASS object.codeBase: setAttribute() to object "test-valueOf" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
+PASS object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get
PASS object.codeBase: IDL set to "" should not throw
PASS object.codeBase: IDL set to "" followed by getAttribute()
-FAIL object.codeBase: IDL set to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
+PASS object.codeBase: IDL set to "" followed by IDL get
PASS object.codeBase: IDL set to " foo " should not throw
PASS object.codeBase: IDL set to " foo " followed by getAttribute()
-FAIL object.codeBase: IDL set to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
+PASS object.codeBase: IDL set to " foo " followed by IDL get
PASS object.codeBase: IDL set to "http://site.example/" should not throw
PASS object.codeBase: IDL set to "http://site.example/" followed by getAttribute()
PASS object.codeBase: IDL set to "http://site.example/" followed by IDL get
PASS object.codeBase: IDL set to "//site.example/path???@#l" should not throw
PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by getAttribute()
-FAIL object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
+PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get
PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " should not throw
PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
-FAIL object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
+PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
PASS object.codeBase: IDL set to undefined should not throw
PASS object.codeBase: IDL set to undefined followed by getAttribute()
-FAIL object.codeBase: IDL set to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
+PASS object.codeBase: IDL set to undefined followed by IDL get
PASS object.codeBase: IDL set to 7 should not throw
PASS object.codeBase: IDL set to 7 followed by getAttribute()
-FAIL object.codeBase: IDL set to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
+PASS object.codeBase: IDL set to 7 followed by IDL get
PASS object.codeBase: IDL set to 1.5 should not throw
PASS object.codeBase: IDL set to 1.5 followed by getAttribute()
-FAIL object.codeBase: IDL set to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
+PASS object.codeBase: IDL set to 1.5 followed by IDL get
PASS object.codeBase: IDL set to true should not throw
PASS object.codeBase: IDL set to true followed by getAttribute()
-FAIL object.codeBase: IDL set to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
+PASS object.codeBase: IDL set to true followed by IDL get
PASS object.codeBase: IDL set to false should not throw
PASS object.codeBase: IDL set to false followed by getAttribute()
-FAIL object.codeBase: IDL set to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
+PASS object.codeBase: IDL set to false followed by IDL get
PASS object.codeBase: IDL set to object "[object Object]" should not throw
PASS object.codeBase: IDL set to object "[object Object]" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
+PASS object.codeBase: IDL set to object "[object Object]" followed by IDL get
PASS object.codeBase: IDL set to NaN should not throw
PASS object.codeBase: IDL set to NaN followed by getAttribute()
-FAIL object.codeBase: IDL set to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
+PASS object.codeBase: IDL set to NaN followed by IDL get
PASS object.codeBase: IDL set to Infinity should not throw
PASS object.codeBase: IDL set to Infinity followed by getAttribute()
-FAIL object.codeBase: IDL set to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
+PASS object.codeBase: IDL set to Infinity followed by IDL get
PASS object.codeBase: IDL set to -Infinity should not throw
PASS object.codeBase: IDL set to -Infinity followed by getAttribute()
-FAIL object.codeBase: IDL set to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
+PASS object.codeBase: IDL set to -Infinity followed by IDL get
PASS object.codeBase: IDL set to "\0" should not throw
PASS object.codeBase: IDL set to "\0" followed by getAttribute()
-FAIL object.codeBase: IDL set to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
+PASS object.codeBase: IDL set to "\0" followed by IDL get
PASS object.codeBase: IDL set to null should not throw
PASS object.codeBase: IDL set to null followed by getAttribute()
-FAIL object.codeBase: IDL set to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
+PASS object.codeBase: IDL set to null followed by IDL get
PASS object.codeBase: IDL set to object "test-toString" should not throw
PASS object.codeBase: IDL set to object "test-toString" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
+PASS object.codeBase: IDL set to object "test-toString" followed by IDL get
PASS object.codeBase: IDL set to object "test-valueOf" should not throw
PASS object.codeBase: IDL set to object "test-valueOf" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
+PASS object.codeBase: IDL set to object "test-valueOf" followed by IDL get
PASS object.codeType: typeof IDL attribute
PASS object.codeType: IDL get with DOM attribute unset
PASS object.codeType: setAttribute() to "" followed by getAttribute()
Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205689 => 205690)
--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
@@ -6337,95 +6337,95 @@
PASS object.codeBase: typeof IDL attribute
PASS object.codeBase: IDL get with DOM attribute unset
PASS object.codeBase: setAttribute() to "" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
+PASS object.codeBase: setAttribute() to "" followed by IDL get
PASS object.codeBase: setAttribute() to " foo " followed by getAttribute()
-FAIL object.codeBase: setAttribute() to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
+PASS object.codeBase: setAttribute() to " foo " followed by IDL get
PASS object.codeBase: setAttribute() to "http://site.example/" followed by getAttribute()
PASS object.codeBase: setAttribute() to "http://site.example/" followed by IDL get
PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
+PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get
PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
+PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
PASS object.codeBase: setAttribute() to undefined followed by getAttribute()
-FAIL object.codeBase: setAttribute() to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
+PASS object.codeBase: setAttribute() to undefined followed by IDL get
PASS object.codeBase: setAttribute() to 7 followed by getAttribute()
-FAIL object.codeBase: setAttribute() to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
+PASS object.codeBase: setAttribute() to 7 followed by IDL get
PASS object.codeBase: setAttribute() to 1.5 followed by getAttribute()
-FAIL object.codeBase: setAttribute() to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
+PASS object.codeBase: setAttribute() to 1.5 followed by IDL get
PASS object.codeBase: setAttribute() to true followed by getAttribute()
-FAIL object.codeBase: setAttribute() to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
+PASS object.codeBase: setAttribute() to true followed by IDL get
PASS object.codeBase: setAttribute() to false followed by getAttribute()
-FAIL object.codeBase: setAttribute() to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
+PASS object.codeBase: setAttribute() to false followed by IDL get
PASS object.codeBase: setAttribute() to object "[object Object]" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
+PASS object.codeBase: setAttribute() to object "[object Object]" followed by IDL get
PASS object.codeBase: setAttribute() to NaN followed by getAttribute()
-FAIL object.codeBase: setAttribute() to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
+PASS object.codeBase: setAttribute() to NaN followed by IDL get
PASS object.codeBase: setAttribute() to Infinity followed by getAttribute()
-FAIL object.codeBase: setAttribute() to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
+PASS object.codeBase: setAttribute() to Infinity followed by IDL get
PASS object.codeBase: setAttribute() to -Infinity followed by getAttribute()
-FAIL object.codeBase: setAttribute() to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
+PASS object.codeBase: setAttribute() to -Infinity followed by IDL get
PASS object.codeBase: setAttribute() to "\0" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
+PASS object.codeBase: setAttribute() to "\0" followed by IDL get
PASS object.codeBase: setAttribute() to null followed by getAttribute()
-FAIL object.codeBase: setAttribute() to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
+PASS object.codeBase: setAttribute() to null followed by IDL get
PASS object.codeBase: setAttribute() to object "test-toString" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
+PASS object.codeBase: setAttribute() to object "test-toString" followed by IDL get
PASS object.codeBase: setAttribute() to object "test-valueOf" followed by getAttribute()
-FAIL object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
+PASS object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get
PASS object.codeBase: IDL set to "" should not throw
PASS object.codeBase: IDL set to "" followed by getAttribute()
-FAIL object.codeBase: IDL set to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
+PASS object.codeBase: IDL set to "" followed by IDL get
PASS object.codeBase: IDL set to " foo " should not throw
PASS object.codeBase: IDL set to " foo " followed by getAttribute()
-FAIL object.codeBase: IDL set to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
+PASS object.codeBase: IDL set to " foo " followed by IDL get
PASS object.codeBase: IDL set to "http://site.example/" should not throw
PASS object.codeBase: IDL set to "http://site.example/" followed by getAttribute()
PASS object.codeBase: IDL set to "http://site.example/" followed by IDL get
PASS object.codeBase: IDL set to "//site.example/path???@#l" should not throw
PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by getAttribute()
-FAIL object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
+PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get
PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " should not throw
PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
-FAIL object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
+PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
PASS object.codeBase: IDL set to undefined should not throw
PASS object.codeBase: IDL set to undefined followed by getAttribute()
-FAIL object.codeBase: IDL set to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
+PASS object.codeBase: IDL set to undefined followed by IDL get
PASS object.codeBase: IDL set to 7 should not throw
PASS object.codeBase: IDL set to 7 followed by getAttribute()
-FAIL object.codeBase: IDL set to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
+PASS object.codeBase: IDL set to 7 followed by IDL get
PASS object.codeBase: IDL set to 1.5 should not throw
PASS object.codeBase: IDL set to 1.5 followed by getAttribute()
-FAIL object.codeBase: IDL set to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
+PASS object.codeBase: IDL set to 1.5 followed by IDL get
PASS object.codeBase: IDL set to true should not throw
PASS object.codeBase: IDL set to true followed by getAttribute()
-FAIL object.codeBase: IDL set to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
+PASS object.codeBase: IDL set to true followed by IDL get
PASS object.codeBase: IDL set to false should not throw
PASS object.codeBase: IDL set to false followed by getAttribute()
-FAIL object.codeBase: IDL set to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
+PASS object.codeBase: IDL set to false followed by IDL get
PASS object.codeBase: IDL set to object "[object Object]" should not throw
PASS object.codeBase: IDL set to object "[object Object]" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
+PASS object.codeBase: IDL set to object "[object Object]" followed by IDL get
PASS object.codeBase: IDL set to NaN should not throw
PASS object.codeBase: IDL set to NaN followed by getAttribute()
-FAIL object.codeBase: IDL set to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
+PASS object.codeBase: IDL set to NaN followed by IDL get
PASS object.codeBase: IDL set to Infinity should not throw
PASS object.codeBase: IDL set to Infinity followed by getAttribute()
-FAIL object.codeBase: IDL set to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
+PASS object.codeBase: IDL set to Infinity followed by IDL get
PASS object.codeBase: IDL set to -Infinity should not throw
PASS object.codeBase: IDL set to -Infinity followed by getAttribute()
-FAIL object.codeBase: IDL set to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
+PASS object.codeBase: IDL set to -Infinity followed by IDL get
PASS object.codeBase: IDL set to "\0" should not throw
PASS object.codeBase: IDL set to "\0" followed by getAttribute()
-FAIL object.codeBase: IDL set to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
+PASS object.codeBase: IDL set to "\0" followed by IDL get
PASS object.codeBase: IDL set to null should not throw
PASS object.codeBase: IDL set to null followed by getAttribute()
-FAIL object.codeBase: IDL set to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
+PASS object.codeBase: IDL set to null followed by IDL get
PASS object.codeBase: IDL set to object "test-toString" should not throw
PASS object.codeBase: IDL set to object "test-toString" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
+PASS object.codeBase: IDL set to object "test-toString" followed by IDL get
PASS object.codeBase: IDL set to object "test-valueOf" should not throw
PASS object.codeBase: IDL set to object "test-valueOf" followed by getAttribute()
-FAIL object.codeBase: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
+PASS object.codeBase: IDL set to object "test-valueOf" followed by IDL get
PASS object.codeType: typeof IDL attribute
PASS object.codeType: IDL get with DOM attribute unset
PASS object.codeType: setAttribute() to "" followed by getAttribute()
Modified: trunk/Source/WebCore/ChangeLog (205689 => 205690)
--- trunk/Source/WebCore/ChangeLog 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/ChangeLog 2016-09-09 03:31:58 UTC (rev 205690)
@@ -1,5 +1,21 @@
2016-09-08 Chris Dumez <[email protected]>
+ HTMLObjectElement.codebase attribute should reflect as a URL
+ https://bugs.webkit.org/show_bug.cgi?id=161768
+
+ Reviewed by Alex Christensen.
+
+ HTMLObjectElement.codebase attribute should reflect as a URL:
+ - https://html.spec.whatwg.org/#dom-applet-codebase
+
+ Chrome and Firefox agree with the specification.
+
+ No new test, rebaselined existing test.
+
+ * html/HTMLObjectElement.idl:
+
+2016-09-08 Chris Dumez <[email protected]>
+
ol.start may return incorrect value for reversed lists when not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=161713
Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (205689 => 205690)
--- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-09-09 03:31:58 UTC (rev 205690)
@@ -362,7 +362,7 @@
bool HTMLObjectElement::isURLAttribute(const Attribute& attribute) const
{
- return attribute.name() == dataAttr || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#') || HTMLPlugInImageElement::isURLAttribute(attribute);
+ return attribute.name() == dataAttr || attribute.name() == codebaseAttr || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#') || HTMLPlugInImageElement::isURLAttribute(attribute);
}
const AtomicString& HTMLObjectElement::imageSourceURL() const
Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (205689 => 205690)
--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-09-09 03:31:58 UTC (rev 205690)
@@ -28,7 +28,7 @@
[Reflect] attribute DOMString align;
[Reflect] attribute DOMString archive;
[Reflect, TreatNullAs=EmptyString] attribute DOMString border;
- [Reflect] attribute DOMString codeBase;
+ [Reflect, URL] attribute USVString codeBase;
[Reflect] attribute DOMString codeType;
[Reflect, URL] attribute USVString data;
[Reflect] attribute boolean declare;
