[webkit-changes] [205691] trunk

Thu, 08 Sep 2016 20:49:22 -0700

Title: [205691] trunk
Revision
205691
Author
[email protected]
Date
2016-09-08 20:49:13 -0700 (Thu, 08 Sep 2016)

Log Message

HTMLObjectElement.hspace / vspace attributes should be unsigned
https://bugs.webkit.org/show_bug.cgi?id=161766

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/html/dom/reflection-embedded-expected.txt:

Source/WebCore:

HTMLObjectElement.hspace / vspace attributes should be unsigned:
- https://html.spec.whatwg.org/#HTMLObjectElement-partial

Firefox agrees with the specification but those were signed in WebKit.

No new tests, rebaselined existing test.

* html/HTMLObjectElement.idl:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205690 => 205691)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-09 03:31:58 UTC (rev 205690)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-09 03:49:13 UTC (rev 205691)
@@ -1,5 +1,16 @@
 2016-09-08  Chris Dumez  <[email protected]>
 
+        HTMLObjectElement.hspace / vspace attributes should be unsigned
+        https://bugs.webkit.org/show_bug.cgi?id=161766
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/html/dom/reflection-embedded-expected.txt:
+
+2016-09-08  Chris Dumez  <[email protected]>
+
         HTMLObjectElement.codebase attribute should reflect as a URL
         https://bugs.webkit.org/show_bug.cgi?id=161768

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205690 => 205691)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-09 03:31:58 UTC (rev 205690)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-09 03:49:13 UTC (rev 205691)
@@ -6004,11 +6004,11 @@
 PASS object.hspace: setAttribute() to -2147483649 followed by getAttribute() 
 PASS object.hspace: setAttribute() to -2147483649 followed by IDL get 
 PASS object.hspace: setAttribute() to -2147483648 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.hspace: setAttribute() to -2147483648 followed by IDL get 
 PASS object.hspace: setAttribute() to -36 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS object.hspace: setAttribute() to -36 followed by IDL get 
 PASS object.hspace: setAttribute() to -1 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: setAttribute() to -1 followed by IDL get 
 PASS object.hspace: setAttribute() to 0 followed by getAttribute() 
 PASS object.hspace: setAttribute() to 0 followed by IDL get 
 PASS object.hspace: setAttribute() to 1 followed by getAttribute() 
@@ -6026,7 +6026,7 @@
 PASS object.hspace: setAttribute() to "" followed by getAttribute() 
 PASS object.hspace: setAttribute() to "" followed by IDL get 
 PASS object.hspace: setAttribute() to "-1" followed by getAttribute() 
-FAIL object.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: setAttribute() to "-1" followed by IDL get 
 PASS object.hspace: setAttribute() to "-0" followed by getAttribute() 
 PASS object.hspace: setAttribute() to "-0" followed by IDL get 
 PASS object.hspace: setAttribute() to "0" followed by getAttribute() 
@@ -6123,11 +6123,11 @@
 PASS object.hspace: IDL set to "-0" followed by getAttribute() 
 PASS object.hspace: IDL set to "-0" followed by IDL get 
 PASS object.hspace: IDL set to 2147483648 should not throw 
-FAIL object.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL object.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.hspace: IDL set to 2147483648 followed by getAttribute() 
+PASS object.hspace: IDL set to 2147483648 followed by IDL get 
 PASS object.hspace: IDL set to 4294967295 should not throw 
-FAIL object.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL object.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: IDL set to 4294967295 followed by getAttribute() 
+PASS object.hspace: IDL set to 4294967295 followed by IDL get 
 PASS object.standby: typeof IDL attribute 
 PASS object.standby: IDL get with DOM attribute unset 
 PASS object.standby: setAttribute() to "" followed by getAttribute() 
@@ -6210,11 +6210,11 @@
 PASS object.vspace: setAttribute() to -2147483649 followed by getAttribute() 
 PASS object.vspace: setAttribute() to -2147483649 followed by IDL get 
 PASS object.vspace: setAttribute() to -2147483648 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.vspace: setAttribute() to -2147483648 followed by IDL get 
 PASS object.vspace: setAttribute() to -36 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS object.vspace: setAttribute() to -36 followed by IDL get 
 PASS object.vspace: setAttribute() to -1 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: setAttribute() to -1 followed by IDL get 
 PASS object.vspace: setAttribute() to 0 followed by getAttribute() 
 PASS object.vspace: setAttribute() to 0 followed by IDL get 
 PASS object.vspace: setAttribute() to 1 followed by getAttribute() 
@@ -6232,7 +6232,7 @@
 PASS object.vspace: setAttribute() to "" followed by getAttribute() 
 PASS object.vspace: setAttribute() to "" followed by IDL get 
 PASS object.vspace: setAttribute() to "-1" followed by getAttribute() 
-FAIL object.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: setAttribute() to "-1" followed by IDL get 
 PASS object.vspace: setAttribute() to "-0" followed by getAttribute() 
 PASS object.vspace: setAttribute() to "-0" followed by IDL get 
 PASS object.vspace: setAttribute() to "0" followed by getAttribute() 
@@ -6329,11 +6329,11 @@
 PASS object.vspace: IDL set to "-0" followed by getAttribute() 
 PASS object.vspace: IDL set to "-0" followed by IDL get 
 PASS object.vspace: IDL set to 2147483648 should not throw 
-FAIL object.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL object.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.vspace: IDL set to 2147483648 followed by getAttribute() 
+PASS object.vspace: IDL set to 2147483648 followed by IDL get 
 PASS object.vspace: IDL set to 4294967295 should not throw 
-FAIL object.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL object.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: IDL set to 4294967295 followed by getAttribute() 
+PASS object.vspace: IDL set to 4294967295 followed by IDL get 
 PASS object.codeBase: typeof IDL attribute 
 PASS object.codeBase: IDL get with DOM attribute unset 
 PASS object.codeBase: setAttribute() to "" followed by getAttribute()

Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205690 => 205691)


--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-09 03:31:58 UTC (rev 205690)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-09 03:49:13 UTC (rev 205691)
@@ -6004,11 +6004,11 @@
 PASS object.hspace: setAttribute() to -2147483649 followed by getAttribute() 
 PASS object.hspace: setAttribute() to -2147483649 followed by IDL get 
 PASS object.hspace: setAttribute() to -2147483648 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.hspace: setAttribute() to -2147483648 followed by IDL get 
 PASS object.hspace: setAttribute() to -36 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS object.hspace: setAttribute() to -36 followed by IDL get 
 PASS object.hspace: setAttribute() to -1 followed by getAttribute() 
-FAIL object.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: setAttribute() to -1 followed by IDL get 
 PASS object.hspace: setAttribute() to 0 followed by getAttribute() 
 PASS object.hspace: setAttribute() to 0 followed by IDL get 
 PASS object.hspace: setAttribute() to 1 followed by getAttribute() 
@@ -6026,7 +6026,7 @@
 PASS object.hspace: setAttribute() to "" followed by getAttribute() 
 PASS object.hspace: setAttribute() to "" followed by IDL get 
 PASS object.hspace: setAttribute() to "-1" followed by getAttribute() 
-FAIL object.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: setAttribute() to "-1" followed by IDL get 
 PASS object.hspace: setAttribute() to "-0" followed by getAttribute() 
 PASS object.hspace: setAttribute() to "-0" followed by IDL get 
 PASS object.hspace: setAttribute() to "0" followed by getAttribute() 
@@ -6123,11 +6123,11 @@
 PASS object.hspace: IDL set to "-0" followed by getAttribute() 
 PASS object.hspace: IDL set to "-0" followed by IDL get 
 PASS object.hspace: IDL set to 2147483648 should not throw 
-FAIL object.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL object.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.hspace: IDL set to 2147483648 followed by getAttribute() 
+PASS object.hspace: IDL set to 2147483648 followed by IDL get 
 PASS object.hspace: IDL set to 4294967295 should not throw 
-FAIL object.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL object.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.hspace: IDL set to 4294967295 followed by getAttribute() 
+PASS object.hspace: IDL set to 4294967295 followed by IDL get 
 PASS object.standby: typeof IDL attribute 
 PASS object.standby: IDL get with DOM attribute unset 
 PASS object.standby: setAttribute() to "" followed by getAttribute() 
@@ -6210,11 +6210,11 @@
 PASS object.vspace: setAttribute() to -2147483649 followed by getAttribute() 
 PASS object.vspace: setAttribute() to -2147483649 followed by IDL get 
 PASS object.vspace: setAttribute() to -2147483648 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.vspace: setAttribute() to -2147483648 followed by IDL get 
 PASS object.vspace: setAttribute() to -36 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS object.vspace: setAttribute() to -36 followed by IDL get 
 PASS object.vspace: setAttribute() to -1 followed by getAttribute() 
-FAIL object.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: setAttribute() to -1 followed by IDL get 
 PASS object.vspace: setAttribute() to 0 followed by getAttribute() 
 PASS object.vspace: setAttribute() to 0 followed by IDL get 
 PASS object.vspace: setAttribute() to 1 followed by getAttribute() 
@@ -6232,7 +6232,7 @@
 PASS object.vspace: setAttribute() to "" followed by getAttribute() 
 PASS object.vspace: setAttribute() to "" followed by IDL get 
 PASS object.vspace: setAttribute() to "-1" followed by getAttribute() 
-FAIL object.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: setAttribute() to "-1" followed by IDL get 
 PASS object.vspace: setAttribute() to "-0" followed by getAttribute() 
 PASS object.vspace: setAttribute() to "-0" followed by IDL get 
 PASS object.vspace: setAttribute() to "0" followed by getAttribute() 
@@ -6329,11 +6329,11 @@
 PASS object.vspace: IDL set to "-0" followed by getAttribute() 
 PASS object.vspace: IDL set to "-0" followed by IDL get 
 PASS object.vspace: IDL set to 2147483648 should not throw 
-FAIL object.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL object.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS object.vspace: IDL set to 2147483648 followed by getAttribute() 
+PASS object.vspace: IDL set to 2147483648 followed by IDL get 
 PASS object.vspace: IDL set to 4294967295 should not throw 
-FAIL object.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL object.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS object.vspace: IDL set to 4294967295 followed by getAttribute() 
+PASS object.vspace: IDL set to 4294967295 followed by IDL get 
 PASS object.codeBase: typeof IDL attribute 
 PASS object.codeBase: IDL get with DOM attribute unset 
 PASS object.codeBase: setAttribute() to "" followed by getAttribute()

Modified: trunk/Source/WebCore/ChangeLog (205690 => 205691)


--- trunk/Source/WebCore/ChangeLog	2016-09-09 03:31:58 UTC (rev 205690)
+++ trunk/Source/WebCore/ChangeLog	2016-09-09 03:49:13 UTC (rev 205691)
@@ -1,5 +1,21 @@
 2016-09-08  Chris Dumez  <[email protected]>
 
+        HTMLObjectElement.hspace / vspace attributes should be unsigned
+        https://bugs.webkit.org/show_bug.cgi?id=161766
+
+        Reviewed by Ryosuke Niwa.
+
+        HTMLObjectElement.hspace / vspace attributes should be unsigned:
+        - https://html.spec.whatwg.org/#HTMLObjectElement-partial
+
+        Firefox agrees with the specification but those were signed in WebKit.
+
+        No new tests, rebaselined existing test.
+
+        * html/HTMLObjectElement.idl:
+
+2016-09-08  Chris Dumez  <[email protected]>
+
         HTMLObjectElement.codebase attribute should reflect as a URL
         https://bugs.webkit.org/show_bug.cgi?id=161768

Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (205690 => 205691)


--- trunk/Source/WebCore/html/HTMLObjectElement.idl	2016-09-09 03:31:58 UTC (rev 205690)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl	2016-09-09 03:49:13 UTC (rev 205691)
@@ -33,12 +33,12 @@
     [Reflect, URL] attribute USVString data;
     [Reflect] attribute boolean declare;
     [Reflect] attribute DOMString height;
-    [Reflect] attribute long hspace;
+    [Reflect] attribute unsigned long hspace;
     [Reflect] attribute DOMString name;
     [Reflect] attribute DOMString standby;
     [Reflect] attribute DOMString type;
     [Reflect] attribute DOMString useMap;
-    [Reflect] attribute long vspace;
+    [Reflect] attribute unsigned long vspace;
     [Reflect] attribute DOMString width;
     readonly attribute boolean willValidate;
     readonly attribute ValidityState validity;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to