Title: [206363] trunk/Source/WebInspectorUI
- Revision
- 206363
- Author
- [email protected]
- Date
- 2016-09-25 10:28:07 -0700 (Sun, 25 Sep 2016)
Log Message
Web Inspector: REGRESSION (r203437): DOM not updated when editing Box Model values (border, margin, etc)
https://bugs.webkit.org/show_bug.cgi?id=162522
<rdar://problem/28458203>
Reviewed by Brian Burg.
* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._refresh):
(WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
(WebInspector.BoxModelDetailsSectionRow.prototype._editingEnded):
Drive-by style fix for `delete`. Also removed unused properties.
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
Use priority "important" instead of "!important".
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (206362 => 206363)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-25 16:45:02 UTC (rev 206362)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-25 17:28:07 UTC (rev 206363)
@@ -1,3 +1,19 @@
+2016-09-25 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION (r203437): DOM not updated when editing Box Model values (border, margin, etc)
+ https://bugs.webkit.org/show_bug.cgi?id=162522
+ <rdar://problem/28458203>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/BoxModelDetailsSectionRow.js:
+ (WebInspector.BoxModelDetailsSectionRow.prototype._refresh):
+ (WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
+ (WebInspector.BoxModelDetailsSectionRow.prototype._editingEnded):
+ Drive-by style fix for `delete`. Also removed unused properties.
+ (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
+ Use priority "important" instead of "!important".
+
2016-09-23 Joseph Pecoraro <[email protected]>
Web Inspector: Fix typo in event name
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js (206362 => 206363)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2016-09-25 16:45:02 UTC (rev 206362)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2016-09-25 17:28:07 UTC (rev 206363)
@@ -53,7 +53,7 @@
_refresh()
{
if (this._ignoreNextRefresh) {
- delete this._ignoreNextRefresh;
+ this._ignoreNextRefresh = false;
return;
}
@@ -86,7 +86,7 @@
this._highlightMode = mode;
WebInspector.domTreeManager.highlightDOMNode(nodeId, mode);
} else {
- delete this._highlightMode;
+ this._highlightMode = null;
WebInspector.domTreeManager.hideDOMNodeHighlight();
}
@@ -361,10 +361,8 @@
_editingEnded(element, context)
{
- delete this.originalPropertyData;
- delete this.previousPropertyDataCandidate;
element.removeEventListener("keydown", context.keyDownHandler, false);
- delete this._isEditingMetrics;
+ this._isEditingMetrics = false;
}
_editingCancelled(element, context)
@@ -420,7 +418,7 @@
function toggleInlineStyleProperty(property, value)
{
- this.style.setProperty(property, value, "!important");
+ this.style.setProperty(property, value, "important");
}
function didToggle()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
