Title: [206443] trunk/Source/WebCore
- Revision
- 206443
- Author
- [email protected]
- Date
- 2016-09-27 10:33:21 -0700 (Tue, 27 Sep 2016)
Log Message
Remove an unneeded assert in InspectorOverlay.cpp
https://bugs.webkit.org/show_bug.cgi?id=162581
Reviewed by Alexey Proskuryakov.
This assertion was added to catch unknown issues, but it is firing frequently enough on certain Inspector
tests that it is causing more harm than good.
* inspector/InspectorOverlay.cpp:
(WebCore::buildQuadObjectForCSSRegionContentClip):
(WebCore::evaluateCommandInOverlay):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206442 => 206443)
--- trunk/Source/WebCore/ChangeLog 2016-09-27 17:25:38 UTC (rev 206442)
+++ trunk/Source/WebCore/ChangeLog 2016-09-27 17:33:21 UTC (rev 206443)
@@ -1,3 +1,17 @@
+2016-09-27 Ryan Haddad <[email protected]>
+
+ Remove an unneeded assert in InspectorOverlay.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=162581
+
+ Reviewed by Alexey Proskuryakov.
+
+ This assertion was added to catch unknown issues, but it is firing frequently enough on certain Inspector
+ tests that it is causing more harm than good.
+
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::buildQuadObjectForCSSRegionContentClip):
+ (WebCore::evaluateCommandInOverlay):
+
2016-09-27 Jer Noble <[email protected]>
Remove deprecated ENCRYPTED_MEDIA implementation.
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (206442 => 206443)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2016-09-27 17:25:38 UTC (rev 206442)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2016-09-27 17:33:21 UTC (rev 206443)
@@ -923,8 +923,7 @@
static void evaluateCommandInOverlay(Page* page, Ref<InspectorArray>&& command)
{
- JSC::JSValue result = page->mainFrame().script().evaluate(ScriptSourceCode(makeString("dispatch(", command->toJSONString(), ')')));
- ASSERT_UNUSED(result, result); // There should never be exceptions when evaluating in the overlay page.
+ page->mainFrame().script().evaluate(ScriptSourceCode(makeString("dispatch(", command->toJSONString(), ')')));
}
void InspectorOverlay::evaluateInOverlay(const String& method)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
