Title: [206444] trunk/Source/WebCore
- Revision
- 206444
- Author
- [email protected]
- Date
- 2016-09-27 10:54:49 -0700 (Tue, 27 Sep 2016)
Log Message
Some Now Playing behavior is broken after r206315
https://bugs.webkit.org/show_bug.cgi?id=162625
<rdar://problem/28496755>
Reviewed by Jer Noble.
Reverts the part of our heuristic that disables Now Playing in active tabs in the main window.
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::pageAllowsNowPlayingControls):
* page/Page.cpp:
(WebCore::Page::setViewState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206443 => 206444)
--- trunk/Source/WebCore/ChangeLog 2016-09-27 17:33:21 UTC (rev 206443)
+++ trunk/Source/WebCore/ChangeLog 2016-09-27 17:54:49 UTC (rev 206444)
@@ -1,3 +1,18 @@
+2016-09-27 Wenson Hsieh <[email protected]>
+
+ Some Now Playing behavior is broken after r206315
+ https://bugs.webkit.org/show_bug.cgi?id=162625
+ <rdar://problem/28496755>
+
+ Reviewed by Jer Noble.
+
+ Reverts the part of our heuristic that disables Now Playing in active tabs in the main window.
+
+ * html/MediaElementSession.cpp:
+ (WebCore::MediaElementSession::pageAllowsNowPlayingControls):
+ * page/Page.cpp:
+ (WebCore::Page::setViewState):
+
2016-09-27 Ryan Haddad <[email protected]>
Remove an unneeded assert in InspectorOverlay.cpp
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (206443 => 206444)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2016-09-27 17:33:21 UTC (rev 206443)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2016-09-27 17:54:49 UTC (rev 206444)
@@ -730,8 +730,8 @@
bool MediaElementSession::pageAllowsNowPlayingControls() const
{
- auto page = m_element.document().page();
- return page && !page->isVisibleAndActive();
+ // FIXME: Ideally, we should not allow Now Playing controls for the active tab in the main window.
+ return true;
}
}
Modified: trunk/Source/WebCore/page/Page.cpp (206443 => 206444)
--- trunk/Source/WebCore/page/Page.cpp 2016-09-27 17:33:21 UTC (rev 206443)
+++ trunk/Source/WebCore/page/Page.cpp 2016-09-27 17:54:49 UTC (rev 206444)
@@ -1451,7 +1451,6 @@
ViewState::Flags oldViewState = m_viewState;
- bool wasVisibleAndActive = isVisibleAndActive();
m_viewState = viewState;
m_focusController->setViewState(viewState);
@@ -1468,9 +1467,6 @@
for (auto* observer : m_viewStateChangeObservers)
observer->viewStateDidChange(oldViewState, m_viewState);
-
- if (wasVisibleAndActive != isVisibleAndActive())
- PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary();
}
bool Page::isVisibleAndActive() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
