Title: [208787] trunk/Tools
Revision
208787
Author
[email protected]
Date
2016-11-16 01:08:23 -0800 (Wed, 16 Nov 2016)

Log Message

[Win] WebCore test is failing.
https://bugs.webkit.org/show_bug.cgi?id=164772

Reviewed by Brent Fulgham.

The value of CGRectInfinite is not the same on Windows as on Mac.

* TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (208786 => 208787)


--- trunk/Tools/ChangeLog	2016-11-16 06:51:50 UTC (rev 208786)
+++ trunk/Tools/ChangeLog	2016-11-16 09:08:23 UTC (rev 208787)
@@ -1,3 +1,15 @@
+2016-11-16  Per Arne Vollan  <[email protected]>
+
+        [Win] WebCore test is failing.
+        https://bugs.webkit.org/show_bug.cgi?id=164772
+
+        Reviewed by Brent Fulgham.
+
+        The value of CGRectInfinite is not the same on Windows as on Mac.
+
+        * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
+        (TestWebKitAPI::TEST):
+
 2016-11-15  Alexey Proskuryakov  <[email protected]>
 
         Update Youenn's e-mail addresses.

Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp (208786 => 208787)


--- trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp	2016-11-16 06:51:50 UTC (rev 208786)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp	2016-11-16 09:08:23 UTC (rev 208787)
@@ -712,10 +712,17 @@
 #if USE(CG)
     CGRect cgInfiniteRect = CGRectInfinite;
 
+#if PLATFORM(WIN)
+    EXPECT_FLOAT_EQ(-std::numeric_limits<float>::max() / 2, cgInfiniteRect.origin.x);
+    EXPECT_FLOAT_EQ(-std::numeric_limits<float>::max() / 2, cgInfiniteRect.origin.y);
+    EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.size.width);
+    EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.size.height);
+#else
     EXPECT_FLOAT_EQ(-std::numeric_limits<float>::max(), cgInfiniteRect.origin.x);
     EXPECT_FLOAT_EQ(-std::numeric_limits<float>::max(), cgInfiniteRect.origin.y);
     EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.origin.x + cgInfiniteRect.size.width);
     EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.origin.y + cgInfiniteRect.size.height);
+#endif
     // ASSERT_TRUE(infinite == cgInfiniteRect);
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to