Title: [209367] trunk/Source/_javascript_Core
Revision
209367
Author
[email protected]
Date
2016-12-05 17:01:50 -0800 (Mon, 05 Dec 2016)

Log Message

Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData
https://bugs.webkit.org/show_bug.cgi?id=165413
<rdar://problem/29517587>

Reviewed by Brian Burg.

DOMTimer::removeById can call into InspectorInstrumentation with an
invalid identifier, so don't assert that async call data exists.

* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::derefAsyncCallData):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (209366 => 209367)


--- trunk/Source/_javascript_Core/ChangeLog	2016-12-06 00:21:19 UTC (rev 209366)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-12-06 01:01:50 UTC (rev 209367)
@@ -1,3 +1,17 @@
+2016-12-05  Matt Baker  <[email protected]>
+
+        Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData
+        https://bugs.webkit.org/show_bug.cgi?id=165413
+        <rdar://problem/29517587>
+
+        Reviewed by Brian Burg.
+
+        DOMTimer::removeById can call into InspectorInstrumentation with an
+        invalid identifier, so don't assert that async call data exists.
+
+        * inspector/agents/InspectorDebuggerAgent.cpp:
+        (Inspector::InspectorDebuggerAgent::derefAsyncCallData):
+
 2016-12-05  Geoffrey Garen  <[email protected]>
 
         Fixed a bug in my last patch.

Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp (209366 => 209367)


--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp	2016-12-06 00:21:19 UTC (rev 209366)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp	2016-12-06 01:01:50 UTC (rev 209367)
@@ -1151,7 +1151,6 @@
 void InspectorDebuggerAgent::derefAsyncCallData(const AsyncCallIdentifier& identifier)
 {
     auto iterator = m_asyncCallIdentifierToData.find(identifier);
-    ASSERT(iterator != m_asyncCallIdentifierToData.end());
     if (iterator == m_asyncCallIdentifierToData.end())
         return;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to