Title: [209368] trunk/Source/WebCore
- Revision
- 209368
- Author
- [email protected]
- Date
- 2016-12-05 17:04:59 -0800 (Mon, 05 Dec 2016)
Log Message
[CSS Parser] calcs on column-width that resolve to 0 should be discarded
https://bugs.webkit.org/show_bug.cgi?id=165439
Reviewed by Dean Jackson.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeColumnWidth):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209367 => 209368)
--- trunk/Source/WebCore/ChangeLog 2016-12-06 01:01:50 UTC (rev 209367)
+++ trunk/Source/WebCore/ChangeLog 2016-12-06 01:04:59 UTC (rev 209368)
@@ -1,3 +1,13 @@
+2016-12-05 Dave Hyatt <[email protected]>
+
+ [CSS Parser] calcs on column-width that resolve to 0 should be discarded
+ https://bugs.webkit.org/show_bug.cgi?id=165439
+
+ Reviewed by Dean Jackson.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeColumnWidth):
+
2016-12-05 Dean Jackson <[email protected]>
pointer lock needs to be feature detectable
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (209367 => 209368)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-12-06 01:01:50 UTC (rev 209367)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-12-06 01:04:59 UTC (rev 209368)
@@ -1232,7 +1232,7 @@
// Always parse lengths in strict mode here, since it would be ambiguous otherwise when used in
// the 'columns' shorthand property.
RefPtr<CSSPrimitiveValue> columnWidth = consumeLength(range, HTMLStandardMode, ValueRangeNonNegative);
- if (!columnWidth || (!columnWidth->isCalculated() && columnWidth->doubleValue() == 0))
+ if (!columnWidth || (!columnWidth->isCalculated() && !columnWidth->doubleValue()) || (columnWidth->cssCalcValue() && !columnWidth->cssCalcValue()->doubleValue()))
return nullptr;
return columnWidth;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes