Title: [209402] trunk/Source/WebKit2
Revision
209402
Author
[email protected]
Date
2016-12-06 09:46:23 -0800 (Tue, 06 Dec 2016)

Log Message

Remove unused InjectedBundle::overrideXSSAuditorEnabledForTestRunner()
https://bugs.webkit.org/show_bug.cgi?id=165408

Reviewed by Alex Christensen.

InjectedBundle::overrideXSSAuditorEnabledForTestRunner() is unused. This function was only
called by WKBundleOverrideXSSAuditorEnabledForTestRunner(), which was removed in r106005.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner): Deleted.
* WebProcess/InjectedBundle/InjectedBundle.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (209401 => 209402)


--- trunk/Source/WebKit2/ChangeLog	2016-12-06 17:45:54 UTC (rev 209401)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-06 17:46:23 UTC (rev 209402)
@@ -1,3 +1,17 @@
+2016-12-06  Daniel Bates  <[email protected]>
+
+        Remove unused InjectedBundle::overrideXSSAuditorEnabledForTestRunner()
+        https://bugs.webkit.org/show_bug.cgi?id=165408
+
+        Reviewed by Alex Christensen.
+
+        InjectedBundle::overrideXSSAuditorEnabledForTestRunner() is unused. This function was only
+        called by WKBundleOverrideXSSAuditorEnabledForTestRunner(), which was removed in r106005.
+
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner): Deleted.
+        * WebProcess/InjectedBundle/InjectedBundle.h:
+
 2016-12-04  Darin Adler  <[email protected]>
 
         Use ASCIICType more, and improve it a little bit

Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (209401 => 209402)


--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2016-12-06 17:45:54 UTC (rev 209401)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2016-12-06 17:46:23 UTC (rev 209402)
@@ -268,17 +268,6 @@
 #undef FOR_EACH_OVERRIDE_BOOL_PREFERENCE
 }
 
-void InjectedBundle::overrideXSSAuditorEnabledForTestRunner(WebPageGroupProxy* pageGroup, bool enabled)
-{
-    // Override the preference for all future pages.
-    WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::xssAuditorEnabledKey(), enabled);
-
-    // Change the setting for existing ones.
-    const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
-    for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
-        (*iter)->settings().setXSSAuditorEnabled(enabled);
-}
-
 void InjectedBundle::setAllowUniversalAccessFromFileURLs(WebPageGroupProxy* pageGroup, bool enabled)
 {
     const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();

Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (209401 => 209402)


--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h	2016-12-06 17:45:54 UTC (rev 209401)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h	2016-12-06 17:46:23 UTC (rev 209402)
@@ -99,7 +99,6 @@
 
     // TestRunner only SPI
     void overrideBoolPreferenceForTestRunner(WebPageGroupProxy*, const String& preference, bool enabled);
-    void overrideXSSAuditorEnabledForTestRunner(WebPageGroupProxy* pageGroup, bool enabled);
     void setAllowUniversalAccessFromFileURLs(WebPageGroupProxy*, bool);
     void setAllowFileAccessFromFileURLs(WebPageGroupProxy*, bool);
     void setNeedsStorageAccessFromFileURLsQuirk(WebPageGroupProxy*, bool);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to