Title: [209403] trunk/Source
Revision
209403
Author
[email protected]
Date
2016-12-06 09:46:48 -0800 (Tue, 06 Dec 2016)

Log Message

Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=165451

Reviewed by Alex Christensen.

Source/WebCore:

Rename Document::shouldEnforceHTTP0_9Sandbox() and ResourceResponseBase::isHttpVersion0_9()
to Document::shouldEnforceHTTP09Sandbox() and ResourceResponseBase::isHTTP09, respectively,
to conform to the WebKit Code Style Guidelines.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
(WebCore::Document::shouldEnforceHTTP09Sandbox): Renamed; formerly named shouldEnforceHTTP0_9Sandbox
* dom/Document.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::didReceiveResponse):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isHTTP09): Renamed; formerly named isHttpVersion0_9.
* platform/network/ResourceResponseBase.h:

Source/WebKit2:

* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::didReceiveResponse):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209402 => 209403)


--- trunk/Source/WebCore/ChangeLog	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/ChangeLog	2016-12-06 17:46:48 UTC (rev 209403)
@@ -1,5 +1,26 @@
 2016-12-06  Daniel Bates  <[email protected]>
 
+        Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines
+        https://bugs.webkit.org/show_bug.cgi?id=165451
+
+        Reviewed by Alex Christensen.
+
+        Rename Document::shouldEnforceHTTP0_9Sandbox() and ResourceResponseBase::isHttpVersion0_9()
+        to Document::shouldEnforceHTTP09Sandbox() and ResourceResponseBase::isHTTP09, respectively,
+        to conform to the WebKit Code Style Guidelines.
+
+        * dom/Document.cpp:
+        (WebCore::Document::initSecurityContext):
+        (WebCore::Document::shouldEnforceHTTP09Sandbox): Renamed; formerly named shouldEnforceHTTP0_9Sandbox
+        * dom/Document.h:
+        * platform/network/ResourceHandle.cpp:
+        (WebCore::ResourceHandle::didReceiveResponse):
+        * platform/network/ResourceResponseBase.cpp:
+        (WebCore::ResourceResponseBase::isHTTP09): Renamed; formerly named isHttpVersion0_9.
+        * platform/network/ResourceResponseBase.h:
+
+2016-12-06  Daniel Bates  <[email protected]>
+
         Use Vector::uncheckedAppend() in more places
         https://bugs.webkit.org/show_bug.cgi?id=164952
 

Modified: trunk/Source/WebCore/dom/Document.cpp (209402 => 209403)


--- trunk/Source/WebCore/dom/Document.cpp	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-12-06 17:46:48 UTC (rev 209403)
@@ -5129,7 +5129,7 @@
         applyQuickLookSandbox();
 #endif
 
-    if (shouldEnforceHTTP0_9Sandbox()) {
+    if (shouldEnforceHTTP09Sandbox()) {
         String message = makeString("Sandboxing '", m_url.stringCenterEllipsizedToLength(), "' because it is using HTTP/0.9.");
         addConsoleMessage(MessageSource::Security, MessageLevel::Error, message);
         enforceSandboxFlags(SandboxScripts | SandboxPlugins);
@@ -6919,12 +6919,12 @@
     return ShouldOpenExternalURLsPolicy::ShouldNotAllow;
 }
 
-bool Document::shouldEnforceHTTP0_9Sandbox() const
+bool Document::shouldEnforceHTTP09Sandbox() const
 {
     if (m_isSynthesized || !m_frame)
         return false;
     DocumentLoader* documentLoader = m_frame->loader().activeDocumentLoader();
-    return documentLoader && documentLoader->response().isHttpVersion0_9();
+    return documentLoader && documentLoader->response().isHTTP09();
 }
 
 #if USE(QUICK_LOOK)

Modified: trunk/Source/WebCore/dom/Document.h (209402 => 209403)


--- trunk/Source/WebCore/dom/Document.h	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/dom/Document.h	2016-12-06 17:46:48 UTC (rev 209403)
@@ -1394,7 +1394,7 @@
     void applyQuickLookSandbox();
 #endif
 
-    bool shouldEnforceHTTP0_9Sandbox() const;
+    bool shouldEnforceHTTP09Sandbox() const;
 
     unsigned m_referencingNodeCount;
 

Modified: trunk/Source/WebCore/platform/network/ResourceHandle.cpp (209402 => 209403)


--- trunk/Source/WebCore/platform/network/ResourceHandle.cpp	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/platform/network/ResourceHandle.cpp	2016-12-06 17:46:48 UTC (rev 209403)
@@ -152,7 +152,7 @@
 
 void ResourceHandle::didReceiveResponse(ResourceResponse&& response)
 {
-    if (response.isHttpVersion0_9()) {
+    if (response.isHTTP09()) {
         auto url = ""
         std::optional<uint16_t> port = url.port();
         if (port && !isDefaultPortForProtocol(port.value(), url.protocol())) {

Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp (209402 => 209403)


--- trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp	2016-12-06 17:46:48 UTC (rev 209403)
@@ -278,7 +278,7 @@
     // FIXME: Should invalidate or update platform response if present.
 }
 
-bool ResourceResponseBase::isHttpVersion0_9() const
+bool ResourceResponseBase::isHTTP09() const
 {
     lazyInit(AllFields);
 

Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.h (209402 => 209403)


--- trunk/Source/WebCore/platform/network/ResourceResponseBase.h	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.h	2016-12-06 17:46:48 UTC (rev 209403)
@@ -92,7 +92,7 @@
 
     WEBCORE_EXPORT const String& httpVersion() const;
     WEBCORE_EXPORT void setHTTPVersion(const String&);
-    WEBCORE_EXPORT bool isHttpVersion0_9() const;
+    WEBCORE_EXPORT bool isHTTP09() const;
 
     WEBCORE_EXPORT const HTTPHeaderMap& httpHeaderFields() const;
 

Modified: trunk/Source/WebKit2/ChangeLog (209402 => 209403)


--- trunk/Source/WebKit2/ChangeLog	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-06 17:46:48 UTC (rev 209403)
@@ -1,5 +1,15 @@
 2016-12-06  Daniel Bates  <[email protected]>
 
+        Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines
+        https://bugs.webkit.org/show_bug.cgi?id=165451
+
+        Reviewed by Alex Christensen.
+
+        * NetworkProcess/NetworkDataTask.cpp:
+        (WebKit::NetworkDataTask::didReceiveResponse):
+
+2016-12-06  Daniel Bates  <[email protected]>
+
         Remove unused InjectedBundle::overrideXSSAuditorEnabledForTestRunner()
         https://bugs.webkit.org/show_bug.cgi?id=165408
 

Modified: trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.cpp (209402 => 209403)


--- trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.cpp	2016-12-06 17:46:23 UTC (rev 209402)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.cpp	2016-12-06 17:46:48 UTC (rev 209403)
@@ -97,7 +97,7 @@
 void NetworkDataTask::didReceiveResponse(ResourceResponse&& response, ResponseCompletionHandler&& completionHandler)
 {
     ASSERT(m_client);
-    if (response.isHttpVersion0_9()) {
+    if (response.isHTTP09()) {
         auto url = ""
         std::optional<uint16_t> port = url.port();
         if (port && !isDefaultPortForProtocol(port.value(), url.protocol())) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to