Title: [209703] trunk/Source/WTF
- Revision
- 209703
- Author
- [email protected]
- Date
- 2016-12-12 00:14:58 -0800 (Mon, 12 Dec 2016)
Log Message
Unreviewed, use WTF_ATTRIBUTE_PRINTF instead of clang pragma
* wtf/PrintStream.cpp:
(WTF::PrintStream::printfVariableFormat):
* wtf/PrintStream.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (209702 => 209703)
--- trunk/Source/WTF/ChangeLog 2016-12-12 07:44:40 UTC (rev 209702)
+++ trunk/Source/WTF/ChangeLog 2016-12-12 08:14:58 UTC (rev 209703)
@@ -1,3 +1,11 @@
+2016-12-12 Konstantin Tokarev <[email protected]>
+
+ Unreviewed, use WTF_ATTRIBUTE_PRINTF instead of clang pragma
+
+ * wtf/PrintStream.cpp:
+ (WTF::PrintStream::printfVariableFormat):
+ * wtf/PrintStream.h:
+
2016-12-11 Konstantin Tokarev <[email protected]>
Unreviewed, guarded clang pragma with COMPILER(CLANG) to fix -Werror
Modified: trunk/Source/WTF/wtf/PrintStream.cpp (209702 => 209703)
--- trunk/Source/WTF/wtf/PrintStream.cpp 2016-12-12 07:44:40 UTC (rev 209702)
+++ trunk/Source/WTF/wtf/PrintStream.cpp 2016-12-12 08:14:58 UTC (rev 209703)
@@ -46,17 +46,10 @@
void PrintStream::printfVariableFormat(const char* format, ...)
{
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wformat-nonliteral"
-#endif
va_list argList;
va_start(argList, format);
vprintf(format, argList);
va_end(argList);
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
}
void PrintStream::flush()
Modified: trunk/Source/WTF/wtf/PrintStream.h (209702 => 209703)
--- trunk/Source/WTF/wtf/PrintStream.h 2016-12-12 07:44:40 UTC (rev 209702)
+++ trunk/Source/WTF/wtf/PrintStream.h 2016-12-12 08:14:58 UTC (rev 209703)
@@ -51,7 +51,7 @@
virtual ~PrintStream();
WTF_EXPORT_PRIVATE void printf(const char* format, ...) WTF_ATTRIBUTE_PRINTF(2, 3);
- WTF_EXPORT_PRIVATE void printfVariableFormat(const char* format, ...);
+ WTF_EXPORT_PRIVATE void printfVariableFormat(const char* format, ...) WTF_ATTRIBUTE_PRINTF(2, 3);
virtual void vprintf(const char* format, va_list) WTF_ATTRIBUTE_PRINTF(2, 0) = 0;
// Typically a no-op for many subclasses of PrintStream, this is a hint that
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
