Title: [209704] trunk/Source/WTF
- Revision
- 209704
- Author
- [email protected]
- Date
- 2016-12-12 00:32:01 -0800 (Mon, 12 Dec 2016)
Log Message
Unreviewed, rolling out r209703.
https://bugs.webkit.org/show_bug.cgi?id=165749
Broke Apple builds (Requested by annulen|home on #webkit).
Reverted changeset:
"Unreviewed, use WTF_ATTRIBUTE_PRINTF instead of clang pragma"
http://trac.webkit.org/changeset/209703
Patch by Commit Queue <[email protected]> on 2016-12-12
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (209703 => 209704)
--- trunk/Source/WTF/ChangeLog 2016-12-12 08:14:58 UTC (rev 209703)
+++ trunk/Source/WTF/ChangeLog 2016-12-12 08:32:01 UTC (rev 209704)
@@ -1,3 +1,15 @@
+2016-12-12 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r209703.
+ https://bugs.webkit.org/show_bug.cgi?id=165749
+
+ Broke Apple builds (Requested by annulen|home on #webkit).
+
+ Reverted changeset:
+
+ "Unreviewed, use WTF_ATTRIBUTE_PRINTF instead of clang pragma"
+ http://trac.webkit.org/changeset/209703
+
2016-12-12 Konstantin Tokarev <[email protected]>
Unreviewed, use WTF_ATTRIBUTE_PRINTF instead of clang pragma
Modified: trunk/Source/WTF/wtf/PrintStream.cpp (209703 => 209704)
--- trunk/Source/WTF/wtf/PrintStream.cpp 2016-12-12 08:14:58 UTC (rev 209703)
+++ trunk/Source/WTF/wtf/PrintStream.cpp 2016-12-12 08:32:01 UTC (rev 209704)
@@ -46,10 +46,17 @@
void PrintStream::printfVariableFormat(const char* format, ...)
{
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wformat-nonliteral"
+#endif
va_list argList;
va_start(argList, format);
vprintf(format, argList);
va_end(argList);
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
}
void PrintStream::flush()
Modified: trunk/Source/WTF/wtf/PrintStream.h (209703 => 209704)
--- trunk/Source/WTF/wtf/PrintStream.h 2016-12-12 08:14:58 UTC (rev 209703)
+++ trunk/Source/WTF/wtf/PrintStream.h 2016-12-12 08:32:01 UTC (rev 209704)
@@ -51,7 +51,7 @@
virtual ~PrintStream();
WTF_EXPORT_PRIVATE void printf(const char* format, ...) WTF_ATTRIBUTE_PRINTF(2, 3);
- WTF_EXPORT_PRIVATE void printfVariableFormat(const char* format, ...) WTF_ATTRIBUTE_PRINTF(2, 3);
+ WTF_EXPORT_PRIVATE void printfVariableFormat(const char* format, ...);
virtual void vprintf(const char* format, va_list) WTF_ATTRIBUTE_PRINTF(2, 0) = 0;
// Typically a no-op for many subclasses of PrintStream, this is a hint that
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
