Title: [212838] trunk/Source/WebInspectorUI
- Revision
- 212838
- Author
- [email protected]
- Date
- 2017-02-22 09:56:52 -0800 (Wed, 22 Feb 2017)
Log Message
Web Inspector: RTL: Settings tab labels need adjustment
https://bugs.webkit.org/show_bug.cgi?id=168497
Reviewed by Matt Baker.
Flip margins. Use 'text-align: end' instead of manually choosing
right and left based on body[dir].
* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .setting-container > .setting-name):
(body[dir=ltr] .content-view.settings > .setting-container > .setting-name):
(body[dir=rtl] .content-view.settings > .setting-container > .setting-name):
(.content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
(.content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (212837 => 212838)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-22 17:52:58 UTC (rev 212837)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-22 17:56:52 UTC (rev 212838)
@@ -1,3 +1,24 @@
+2017-02-22 Brian Burg <[email protected]>
+
+ Web Inspector: RTL: Settings tab labels need adjustment
+ https://bugs.webkit.org/show_bug.cgi?id=168497
+
+ Reviewed by Matt Baker.
+
+ Flip margins. Use 'text-align: end' instead of manually choosing
+ right and left based on body[dir].
+
+ * UserInterface/Views/SettingsTabContentView.css:
+ (.content-view.settings > .setting-container > .setting-name):
+ (body[dir=ltr] .content-view.settings > .setting-container > .setting-name):
+ (body[dir=rtl] .content-view.settings > .setting-container > .setting-name):
+ (.content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
+ (body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
+ (body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]):
+ (.content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
+ (body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
+ (body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]):
+
2017-02-21 Devin Rousso <[email protected]>
Web Inspector: Prefer Resources tab over Network tab when showing files
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css (212837 => 212838)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css 2017-02-22 17:52:58 UTC (rev 212837)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css 2017-02-22 17:56:52 UTC (rev 212838)
@@ -45,10 +45,19 @@
.content-view.settings > .setting-container > .setting-name {
width: 50%;
- margin-right: 6px;
- text-align: right;
+ text-align: end;
+
+ --setting-name-margin-end: 6px;
}
+body[dir=ltr] .content-view.settings > .setting-container > .setting-name {
+ margin-right: var(--setting-name-margin-end);
+}
+
+body[dir=rtl] .content-view.settings > .setting-container > .setting-name {
+ margin-left: var(--setting-name-margin-end);
+}
+
.content-view.settings > .setting-container > .setting-value-controller {
display: flex;
align-items: center;
@@ -61,9 +70,18 @@
.content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"] {
font-size: 16px;
- margin-right: 4px;
+
+ --settings-input-checkbox-margin-end: 4px;
}
+body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"] {
+ margin-right: var(--settings-input-checkbox-margin-end);
+}
+
+body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"] {
+ margin-left: var(--settings-input-checkbox-margin-end);
+}
+
.content-view.settings > .setting-container > .setting-value-controller select {
/*
To set the font-size of <select> to be exactly 13px, it needs to be set to 16px.
@@ -78,6 +96,19 @@
.content-view.settings > .setting-container > .setting-value-controller input[type="number"] {
max-width: 48px;
- margin: 0 5px 0 2px;
- text-align: right;
+ margin: 0;
+ text-align: end;
+
+ --settings-input-number-margin-start: 2px;
+ --settings-input-number-margin-end: 5px;
}
+
+body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="number"] {
+ margin-left: var(--settings-input-number-margin-start);
+ margin-right: var(--settings-input-number-margin-end);
+}
+
+body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="number"] {
+ margin-left: var(--settings-input-number-margin-end);
+ margin-right: var(--settings-input-number-margin-start);
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
