Title: [212839] trunk/Tools
- Revision
- 212839
- Author
- [email protected]
- Date
- 2017-02-22 10:03:13 -0800 (Wed, 22 Feb 2017)
Log Message
[GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
https://bugs.webkit.org/show_bug.cgi?id=168721
Patch by Carlos Garcia Campos <[email protected]> on 2017-02-22
Reviewed by Michael Catanzaro.
Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
criticals.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::continuousMouseScrollBy):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (212838 => 212839)
--- trunk/Tools/ChangeLog 2017-02-22 17:56:52 UTC (rev 212838)
+++ trunk/Tools/ChangeLog 2017-02-22 18:03:13 UTC (rev 212839)
@@ -1,3 +1,16 @@
+2017-02-22 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
+ https://bugs.webkit.org/show_bug.cgi?id=168721
+
+ Reviewed by Michael Catanzaro.
+
+ Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
+ criticals.
+
+ * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+ (WTR::EventSenderProxy::continuousMouseScrollBy):
+
2017-02-21 Youenn Fablet <[email protected]>
[WebRTC][Mac] Activate libwebrtc
Modified: trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (212838 => 212839)
--- trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2017-02-22 17:56:52 UTC (rev 212838)
+++ trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2017-02-22 18:03:13 UTC (rev 212839)
@@ -441,7 +441,10 @@
void EventSenderProxy::continuousMouseScrollBy(int horizontal, int vertical, bool paged)
{
// Gtk+ does not support paged scroll events.
- g_return_if_fail(!paged);
+ if (paged) {
+ WTFLogAlways("EventSenderProxy::continuousMouseScrollBy not implemented for paged scroll events");
+ return;
+ }
GdkEvent* event = gdk_event_new(GDK_SCROLL);
event->scroll.x = m_position.x;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
