Title: [213530] trunk/Tools
- Revision
- 213530
- Author
- [email protected]
- Date
- 2017-03-07 12:05:50 -0800 (Tue, 07 Mar 2017)
Log Message
webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
https://bugs.webkit.org/show_bug.cgi?id=169220
<rdar://problem/30879645>
Reviewed by Daniel Bates.
Provide more specific port setup functions for iOS ports to allow more sharing of common code.
* Scripts/webkitpy/port/ios.py:
(IOSPort):
(IOSPort._create_devices): Added.
(IOSPort.setup_test_run): Shared iOS device setup code.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort._create_devices): Renamed from setup_test_run.
(IOSSimulatorPort.setup_test_run): Renamed as _create_devices.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (213529 => 213530)
--- trunk/Tools/ChangeLog 2017-03-07 19:27:51 UTC (rev 213529)
+++ trunk/Tools/ChangeLog 2017-03-07 20:05:50 UTC (rev 213530)
@@ -1,3 +1,21 @@
+2017-03-07 Jonathan Bedard <[email protected]>
+
+ webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
+ https://bugs.webkit.org/show_bug.cgi?id=169220
+ <rdar://problem/30879645>
+
+ Reviewed by Daniel Bates.
+
+ Provide more specific port setup functions for iOS ports to allow more sharing of common code.
+
+ * Scripts/webkitpy/port/ios.py:
+ (IOSPort):
+ (IOSPort._create_devices): Added.
+ (IOSPort.setup_test_run): Shared iOS device setup code.
+ * Scripts/webkitpy/port/ios_simulator.py:
+ (IOSSimulatorPort._create_devices): Renamed from setup_test_run.
+ (IOSSimulatorPort.setup_test_run): Renamed as _create_devices.
+
2017-03-07 Anders Carlsson <[email protected]>
Rewrite the DRT Pasteboard implementation to use UTIs and WTF types
Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (213529 => 213530)
--- trunk/Tools/Scripts/webkitpy/port/ios.py 2017-03-07 19:27:51 UTC (rev 213529)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py 2017-03-07 20:05:50 UTC (rev 213530)
@@ -76,3 +76,9 @@
if self.using_multiple_devices():
return self._testing_device(number)
return self._current_device
+
+ def _create_devices(self, device_class):
+ raise NotImplementedError
+
+ def setup_test_run(self, device_class=None):
+ self._create_devices(device_class)
Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (213529 => 213530)
--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-03-07 19:27:51 UTC (rev 213529)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-03-07 20:05:50 UTC (rev 213530)
@@ -210,7 +210,7 @@
_log.warn("Expected simulator of type '" + self.simulator_device_type().name + "' but found simulator of type '" + self._current_device.name + "'")
_log.warn('The next block of tests may fail due to device mis-match')
- def setup_test_run(self, device_class=None):
+ def _create_devices(self, device_class):
mac_os_version = self.host.platform.os_version
self._set_device_class(device_class)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
