Title: [213531] trunk/LayoutTests
- Revision
- 213531
- Author
- [email protected]
- Date
- 2017-03-07 12:16:03 -0800 (Tue, 07 Mar 2017)
Log Message
Flaky Test: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html
https://bugs.webkit.org/show_bug.cgi?id=169159
Patch by Antoine Quint <[email protected]> on 2017-03-07
Reviewed by Dean Jackson.
Make this test more defensive to ensure it doesn't fail.
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213530 => 213531)
--- trunk/LayoutTests/ChangeLog 2017-03-07 20:05:50 UTC (rev 213530)
+++ trunk/LayoutTests/ChangeLog 2017-03-07 20:16:03 UTC (rev 213531)
@@ -1,3 +1,16 @@
+2017-03-07 Antoine Quint <[email protected]>
+
+ Flaky Test: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html
+ https://bugs.webkit.org/show_bug.cgi?id=169159
+
+ Reviewed by Dean Jackson.
+
+ Make this test more defensive to ensure it doesn't fail.
+
+ * media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
+ * media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
+ * platform/mac/TestExpectations:
+
2017-03-07 Myles C. Maxfield <[email protected]>
Parsing font descriptors inside @font-face needs to accept ranges
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt (213530 => 213531)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt 2017-03-07 20:05:50 UTC (rev 213530)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt 2017-03-07 20:16:03 UTC (rev 213531)
@@ -7,7 +7,8 @@
media.audioTracks[1].enabled = false
media.audioTracks[2].enabled = false
-PASS shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width became different from 0
+PASS shadowRoot.querySelector('button.tracks') became different from null
+PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect().width became different from 0
Clicking on the tracks button
Clicking on second audio track in tracks panel
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html (213530 => 213531)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html 2017-03-07 20:05:50 UTC (rev 213530)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html 2017-03-07 20:16:03 UTC (rev 213531)
@@ -21,8 +21,10 @@
media.audioTracks.addEventListener("change", audioTracksDidChange);
debug("");
- shouldBecomeDifferent("shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width", "0", () => {
- clickOnTracksButton(clickOnSecondAudioTrack);
+ shouldBecomeDifferent("shadowRoot.querySelector('button.tracks')", "null", () => {
+ shouldBecomeDifferent("shadowRoot.querySelector('button.tracks').getBoundingClientRect().width", "0", () => {
+ clickOnTracksButton(clickOnSecondAudioTrack);
+ });
});
});
Modified: trunk/LayoutTests/platform/mac/TestExpectations (213530 => 213531)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-03-07 20:05:50 UTC (rev 213530)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-03-07 20:16:03 UTC (rev 213531)
@@ -1484,7 +1484,6 @@
webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
-webkit.org/b/169519 media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html [ Pass Failure ]
webkit.org/b/169158 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
webkit.org/b/167373 media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
