Title: [214904] trunk/Source/_javascript_Core
- Revision
- 214904
- Author
- [email protected]
- Date
- 2017-04-04 15:19:38 -0700 (Tue, 04 Apr 2017)
Log Message
WasmBench asserts in debug jsc
https://bugs.webkit.org/show_bug.cgi?id=170462
Reviewed by Saam Barati.
The assertion should have been an if.
* wasm/WasmWorklist.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (214903 => 214904)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-04 22:14:31 UTC (rev 214903)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-04 22:19:38 UTC (rev 214904)
@@ -1,3 +1,14 @@
+2017-04-04 Keith Miller <[email protected]>
+
+ WasmBench asserts in debug jsc
+ https://bugs.webkit.org/show_bug.cgi?id=170462
+
+ Reviewed by Saam Barati.
+
+ The assertion should have been an if.
+
+ * wasm/WasmWorklist.cpp:
+
2017-04-04 Filip Pizlo <[email protected]>
Air::lowerAfterRegAlloc should bail early if it finds no Shuffles or ColdCCalls
Modified: trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp (214903 => 214904)
--- trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp 2017-04-04 22:14:31 UTC (rev 214903)
+++ trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp 2017-04-04 22:19:38 UTC (rev 214904)
@@ -115,9 +115,8 @@
// FIXME: this should check in occasionally to see if there are new, higher priority e.g. synchronous, plans that need to be run.
// https://bugs.webkit.org/show_bug.cgi?id=170204
plan->compileFunctions(Plan::Partial);
- ASSERT(!plan->hasWork());
- {
+ if (!plan->hasWork()) {
LockHolder locker(*worklist.m_lock);
auto queue = worklist.m_queue;
// Another thread may have removed our plan from the queue already.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
