Title: [214906] trunk/Source/WebInspectorUI
- Revision
- 214906
- Author
- [email protected]
- Date
- 2017-04-04 15:23:46 -0700 (Tue, 04 Apr 2017)
Log Message
Web Inspector: RTL: layout issues in Type Profiler popovers
https://bugs.webkit.org/show_bug.cgi?id=170467
Reviewed by Timothy Hatcher.
Flip some margins and padding. Remove the -1px leading margin for
the prototype disclosure button, as it is unnecessary and looks
(more) wrong when in RTL.
* UserInterface/Views/TypeTreeElement.css:
(.item.type-tree-element > .disclosure-button):
(.item.type-tree-element.prototype):
(body[dir=ltr] .item.type-tree-element.prototype):
(body[dir=rtl] .item.type-tree-element.prototype):
* UserInterface/Views/TypeTreeView.css:
(.tree-outline.type):
(body[dir=ltr] .tree-outline.type):
(body[dir=rtl] .tree-outline.type):
(.tree-outline.type li .empty-message):
(body[dir=ltr] .tree-outline.type li .empty-message):
(body[dir=rtl] .tree-outline.type li .empty-message):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214905 => 214906)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-04 22:23:37 UTC (rev 214905)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-04 22:23:46 UTC (rev 214906)
@@ -1,3 +1,27 @@
+2017-04-04 Brian Burg <[email protected]>
+
+ Web Inspector: RTL: layout issues in Type Profiler popovers
+ https://bugs.webkit.org/show_bug.cgi?id=170467
+
+ Reviewed by Timothy Hatcher.
+
+ Flip some margins and padding. Remove the -1px leading margin for
+ the prototype disclosure button, as it is unnecessary and looks
+ (more) wrong when in RTL.
+
+ * UserInterface/Views/TypeTreeElement.css:
+ (.item.type-tree-element > .disclosure-button):
+ (.item.type-tree-element.prototype):
+ (body[dir=ltr] .item.type-tree-element.prototype):
+ (body[dir=rtl] .item.type-tree-element.prototype):
+ * UserInterface/Views/TypeTreeView.css:
+ (.tree-outline.type):
+ (body[dir=ltr] .tree-outline.type):
+ (body[dir=rtl] .tree-outline.type):
+ (.tree-outline.type li .empty-message):
+ (body[dir=ltr] .tree-outline.type li .empty-message):
+ (body[dir=rtl] .tree-outline.type li .empty-message):
+
2017-04-04 Joseph Pecoraro <[email protected]>
Web Inspector: Include more Network information in Resource Details Sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css (214905 => 214906)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2017-04-04 22:23:37 UTC (rev 214905)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2017-04-04 22:23:46 UTC (rev 214906)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -46,7 +46,6 @@
width: 15px;
- margin-left: -1px;
border: 0;
background: none;
-webkit-appearance: none;
@@ -75,10 +74,24 @@
background-color: hsla(0, 0%, 0%, 0.03);
border-radius: 3px;
- padding: 0 10px 1px 0;
- margin: 3px 0 2px -1px;
+ padding-bottom: 1px;
+ margin-top: 3px;
+ margin-bottom: 2px;
+
+ --type-tree-element-prototype-padding-end: 10px;
+ --type-tree-element-prototype-margin-start: -1px;
}
+body[dir=ltr] .item.type-tree-element.prototype {
+ padding-right: var(--type-tree-element-prototype-padding-end);
+ margin-left: var(--type-tree-element-prototype-margin-start);
+}
+
+body[dir=rtl] .item.type-tree-element.prototype {
+ padding-left: var(--type-tree-element-prototype-padding-end);
+ margin-right: var(--type-tree-element-prototype-margin-start);
+}
+
.item.type-tree-element.prototype:hover,
.item.type-tree-element.prototype:focus {
border-color: hsla(0, 0%, 0%, 0.1);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css (214905 => 214906)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2017-04-04 22:23:37 UTC (rev 214905)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2017-04-04 22:23:46 UTC (rev 214906)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -34,12 +34,23 @@
.tree-outline.type {
margin: 0;
- padding: 0 6px 2px;
+ padding-bottom: 2px;
+ min-height: 18px;
+
list-style: none;
- min-height: 18px;
outline: none;
+
+ --type-tree-outline-padding-end: 6px;
}
+body[dir=ltr] .tree-outline.type {
+ padding-right: var(--type-tree-outline-padding-end);
+}
+
+body[dir=rtl] .tree-outline.type {
+ padding-left: var(--type-tree-outline-padding-end);
+}
+
.tree-outline.type li {
padding: 0;
white-space: nowrap;
@@ -62,5 +73,14 @@
.tree-outline.type li .empty-message {
color: hsl(0, 0%, 60%);
- margin-left: 13px;
+
+ --type-tree-outline-empty-message-margin-start: 13px;
}
+
+body[dir=ltr] .tree-outline.type li .empty-message {
+ margin-left: var(--type-tree-outline-empty-message-margin-start);
+}
+
+body[dir=rtl] .tree-outline.type li .empty-message {
+ margin-right: var(--type-tree-outline-empty-message-margin-start);
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
