Title: [214911] trunk/Tools
- Revision
- 214911
- Author
- [email protected]
- Date
- 2017-04-04 16:32:03 -0700 (Tue, 04 Apr 2017)
Log Message
Various settings in Minibrowser are off by default, and should be on
https://bugs.webkit.org/show_bug.cgi?id=170465
rdar://problem/31421543
Reviewed by Tim Horton.
Explicitly set preferences that should be on by default to enabled, if they have not been
set previously.
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController init]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (214910 => 214911)
--- trunk/Tools/ChangeLog 2017-04-04 22:57:22 UTC (rev 214910)
+++ trunk/Tools/ChangeLog 2017-04-04 23:32:03 UTC (rev 214911)
@@ -1,3 +1,17 @@
+2017-04-04 Simon Fraser <[email protected]>
+
+ Various settings in Minibrowser are off by default, and should be on
+ https://bugs.webkit.org/show_bug.cgi?id=170465
+ rdar://problem/31421543
+
+ Reviewed by Tim Horton.
+
+ Explicitly set preferences that should be on by default to enabled, if they have not been
+ set previously.
+
+ * MiniBrowser/mac/SettingsController.m:
+ (-[SettingsController init]):
+
2017-04-04 JF Bastien <[email protected]>
Add JF Bastien as reviewer
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (214910 => 214911)
--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2017-04-04 22:57:22 UTC (rev 214910)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2017-04-04 23:32:03 UTC (rev 214911)
@@ -93,6 +93,33 @@
return sharedSettingsController;
}
+- (instancetype)init
+{
+ self = [super init];
+ if (!self)
+ return nil;
+
+ NSArray *_onByDefaultPrefs_ = @[
+ UseWebKit2ByDefaultPreferenceKey,
+ AcceleratedDrawingEnabledPreferenceKey,
+ SimpleLineLayoutEnabledPreferenceKey,
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
+ SubpixelAntialiasedLayerTextEnabledPreferenceKey,
+#endif
+ VisualViewportEnabledPreferenceKey,
+ LargeImageAsyncDecodingEnabledPreferenceKey,
+ AnimatedImageAsyncDecodingEnabledPreferenceKey,
+ ];
+
+ NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
+ for (NSString *prefName in onByDefaultPrefs) {
+ if (![userDefaults objectForKey:prefName])
+ [userDefaults setBool:YES forKey:prefName];
+ }
+
+ return self;
+}
+
- (NSMenu *)menu
{
if (!_menu)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes