Title: [214913] trunk
- Revision
- 214913
- Author
- [email protected]
- Date
- 2017-04-04 16:37:55 -0700 (Tue, 04 Apr 2017)
Log Message
LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=169481
Patch by Youenn Fablet <[email protected]> on 2017-04-04
Reviewed by Eric Carlson.
Source/WebCore:
No need to enumerate all network interfaces in most layout tests.
Adding an Internals API for that in case we want to use TCP localhost candidates.
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setEnumeratingAllNetworkInterfacesEnabled):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* platform/mac-wk2/TestExpectations: Removing flaky expectation.
* webrtc/datachannel/basic.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (214912 => 214913)
--- trunk/LayoutTests/ChangeLog 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/ChangeLog 2017-04-04 23:37:55 UTC (rev 214913)
@@ -1,3 +1,13 @@
+2017-04-04 Youenn Fablet <[email protected]>
+
+ LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=169481
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac-wk2/TestExpectations: Removing flaky expectation.
+ * webrtc/datachannel/basic.html:
+
2017-04-04 Ryan Haddad <[email protected]>
Add back results that were accidentally removed with r214848.
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (214912 => 214913)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-04 23:37:55 UTC (rev 214913)
@@ -641,8 +641,6 @@
webkit.org/b/168346 [ Sierra Debug ] editing/selection/move-by-word-visually-multi-space.html [ Pass Timeout ]
-webkit.org/b/169481 [ Debug ] webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
-
webkit.org/b/169621 imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html [ Pass Failure ]
webkit.org/b/169760 imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html [ Pass Failure ]
Modified: trunk/LayoutTests/webrtc/datachannel/basic.html (214912 => 214913)
--- trunk/LayoutTests/webrtc/datachannel/basic.html 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/LayoutTests/webrtc/datachannel/basic.html 2017-04-04 23:37:55 UTC (rev 214913)
@@ -102,8 +102,10 @@
promise_test((test) => {
counter = 0;
return new Promise((resolve, reject) => {
- if (window.internals)
+ if (window.internals) {
internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
+ internals.setEnumeratingAllNetworkInterfacesEnabled(true);
+ }
finishTest = resolve;
createConnections((localConnection) => {
Modified: trunk/Source/WebCore/ChangeLog (214912 => 214913)
--- trunk/Source/WebCore/ChangeLog 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/ChangeLog 2017-04-04 23:37:55 UTC (rev 214913)
@@ -1,3 +1,20 @@
+2017-04-04 Youenn Fablet <[email protected]>
+
+ LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=169481
+
+ Reviewed by Eric Carlson.
+
+ No need to enumerate all network interfaces in most layout tests.
+ Adding an Internals API for that in case we want to use TCP localhost candidates.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::Internals):
+ (WebCore::Internals::setEnumeratingAllNetworkInterfacesEnabled):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
+
2017-04-04 Jer Noble <[email protected]>
Unreviewed build fix: fix compilation error on Sierra.
Modified: trunk/Source/WebCore/testing/Internals.cpp (214912 => 214913)
--- trunk/Source/WebCore/testing/Internals.cpp 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.cpp 2017-04-04 23:37:55 UTC (rev 214913)
@@ -470,10 +470,8 @@
enableMockMediaEndpoint();
useMockRTCPeerConnectionFactory(String());
#if USE(LIBWEBRTC)
- if (document.page()) {
- document.page()->libWebRTCProvider().enableEnumeratingAllNetworkInterfaces();
+ if (document.page())
document.page()->rtcController().disableICECandidateFiltering();
- }
#endif
#endif
@@ -1253,8 +1251,25 @@
rtcController.disableICECandidateFiltering();
}
+void Internals::setEnumeratingAllNetworkInterfacesEnabled(bool enabled)
+{
+#if USE(LIBWEBRTC)
+ Document* document = contextDocument();
+ auto* page = document->page();
+ if (!page)
+ return;
+ auto& rtcProvider = page->libWebRTCProvider();
+ if (enabled)
+ rtcProvider.enableEnumeratingAllNetworkInterfaces();
+ else
+ rtcProvider.disableEnumeratingAllNetworkInterfaces();
+#else
+ UNUSED_PARAM(enabled);
#endif
+}
+#endif
+
#if ENABLE(MEDIA_STREAM)
void Internals::setMockMediaCaptureDevicesEnabled(bool enabled)
Modified: trunk/Source/WebCore/testing/Internals.h (214912 => 214913)
--- trunk/Source/WebCore/testing/Internals.h 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.h 2017-04-04 23:37:55 UTC (rev 214913)
@@ -422,6 +422,7 @@
void emulateRTCPeerConnectionPlatformEvent(RTCPeerConnection&, const String& action);
void useMockRTCPeerConnectionFactory(const String&);
void setICECandidateFiltering(bool);
+ void setEnumeratingAllNetworkInterfacesEnabled(bool);
#endif
String getImageSourceURL(Element&);
Modified: trunk/Source/WebCore/testing/Internals.idl (214912 => 214913)
--- trunk/Source/WebCore/testing/Internals.idl 2017-04-04 23:32:28 UTC (rev 214912)
+++ trunk/Source/WebCore/testing/Internals.idl 2017-04-04 23:37:55 UTC (rev 214913)
@@ -458,6 +458,7 @@
[Conditional=WEB_RTC] void emulateRTCPeerConnectionPlatformEvent(RTCPeerConnection connection, DOMString action);
[Conditional=WEB_RTC] void useMockRTCPeerConnectionFactory(DOMString testCase);
[Conditional=WEB_RTC] void setICECandidateFiltering(boolean enabled);
+ [Conditional=WEB_RTC] void setEnumeratingAllNetworkInterfacesEnabled(boolean enabled);
[Conditional=VIDEO] void simulateSystemSleep();
[Conditional=VIDEO] void simulateSystemWake();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
