Modified: trunk/Source/WebKit2/ChangeLog (215551 => 215552)
--- trunk/Source/WebKit2/ChangeLog 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-20 05:26:51 UTC (rev 215552)
@@ -1,3 +1,13 @@
+2017-04-19 Joseph Pecoraro <[email protected]>
+
+ Remove WebKitTestRunner code for enabling features that are already enabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=171033
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
2017-04-19 Youenn Fablet <[email protected]>
[Mac] Allow customizing H264 encoder
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (215551 => 215552)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2017-04-20 05:26:51 UTC (rev 215552)
@@ -184,11 +184,6 @@
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(enabled);
#endif
-#if ENABLE(FETCH_API)
- if (preference == "WebKitFetchAPIEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(enabled);
-#endif
-
#if ENABLE(STREAMS_API)
if (preference == "WebKitReadableByteStreamAPIEnabled")
RuntimeEnabledFeatures::sharedFeatures().setReadableByteStreamAPIEnabled(enabled);
@@ -196,20 +191,9 @@
RuntimeEnabledFeatures::sharedFeatures().setWritableStreamAPIEnabled(enabled);
#endif
-#if ENABLE(DOWNLOAD_ATTRIBUTE)
- if (preference == "WebKitDownloadAttributeEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled(enabled);
-#endif
-
- if (preference == "WebKitShadowDOMEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
-
if (preference == "WebKitCSSGridLayoutEnabled")
RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);
- if (preference == "WebKitCustomElementsEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(enabled);
-
if (preference == "WebKitInteractiveFormValidationEnabled")
RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(enabled);
Modified: trunk/Tools/ChangeLog (215551 => 215552)
--- trunk/Tools/ChangeLog 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Tools/ChangeLog 2017-04-20 05:26:51 UTC (rev 215552)
@@ -1,3 +1,19 @@
+2017-04-19 Joseph Pecoraro <[email protected]>
+
+ Remove WebKitTestRunner code for enabling features that are already enabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=171033
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setShadowDOMEnabled): Deleted.
+ (WTR::TestRunner::setCustomElementsEnabled): Deleted.
+ (WTR::TestRunner::setFetchAPIEnabled): Deleted.
+ (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
2017-04-19 Youenn Fablet <[email protected]>
[Mac] Allow customizing H264 encoder
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (215551 => 215552)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2017-04-20 05:26:51 UTC (rev 215552)
@@ -324,19 +324,12 @@
m_testRunner->setUserStyleSheetEnabled(false);
m_testRunner->setXSSAuditorEnabled(false);
- m_testRunner->setShadowDOMEnabled(true);
- m_testRunner->setCustomElementsEnabled(true);
-
m_testRunner->setWebGL2Enabled(true);
m_testRunner->setWebGPUEnabled(true);
- m_testRunner->setFetchAPIEnabled(true);
-
m_testRunner->setWritableStreamAPIEnabled(true);
m_testRunner->setReadableByteStreamAPIEnabled(true);
- m_testRunner->setDownloadAttributeEnabled(true);
-
m_testRunner->setEncryptedMediaAPIEnabled(true);
m_testRunner->setCloseRemainingWindowsWhenComplete(false);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (215551 => 215552)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2017-04-20 05:26:51 UTC (rev 215552)
@@ -346,20 +346,6 @@
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}
-void TestRunner::setShadowDOMEnabled(bool enabled)
-{
- WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitShadowDOMEnabled"));
- auto& injectedBundle = InjectedBundle::singleton();
- WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
-void TestRunner::setCustomElementsEnabled(bool enabled)
-{
- WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitCustomElementsEnabled"));
- auto& injectedBundle = InjectedBundle::singleton();
- WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
void TestRunner::setSubtleCryptoEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitSubtleCryptoEnabled"));
@@ -409,13 +395,6 @@
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}
-void TestRunner::setFetchAPIEnabled(bool enabled)
-{
- WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitFetchAPIEnabled"));
- auto& injectedBundle = InjectedBundle::singleton();
- WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
void TestRunner::setWritableStreamAPIEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWritableStreamAPIEnabled"));
@@ -430,13 +409,6 @@
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}
-void TestRunner::setDownloadAttributeEnabled(bool enabled)
-{
- WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitDownloadAttributeEnabled"));
- auto& injectedBundle = InjectedBundle::singleton();
- WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
void TestRunner::setEncryptedMediaAPIEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitEncryptedMediaAPIEnabled"));
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (215551 => 215552)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2017-04-20 04:36:57 UTC (rev 215551)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2017-04-20 05:26:51 UTC (rev 215552)
@@ -101,12 +101,9 @@
void setCanOpenWindows(bool);
void setCloseRemainingWindowsWhenComplete(bool value) { m_shouldCloseExtraWindows = value; }
void setXSSAuditorEnabled(bool);
- void setShadowDOMEnabled(bool);
- void setCustomElementsEnabled(bool);
void setModernMediaControlsEnabled(bool);
void setWebGL2Enabled(bool);
void setWebGPUEnabled(bool);
- void setFetchAPIEnabled(bool);
void setWritableStreamAPIEnabled(bool);
void setReadableByteStreamAPIEnabled(bool);
@@ -130,7 +127,6 @@
void dispatchPendingLoadRequests();
void setCacheModel(int);
void setAsynchronousSpellCheckingEnabled(bool);
- void setDownloadAttributeEnabled(bool);
void setAllowsAnySSLCertificate(bool);
void setEncryptedMediaAPIEnabled(bool);
void setSubtleCryptoEnabled(bool);
