Title: [215553] trunk/Source/ThirdParty
Revision
215553
Author
[email protected]
Date
2017-04-19 23:26:59 -0700 (Wed, 19 Apr 2017)

Log Message

[GTK] ../../Source/ThirdParty/xdgmime/src/xdgmimecache.c:200:62: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
https://bugs.webkit.org/show_bug.cgi?id=171026

Reviewed by Carlos Garcia Campos.

* xdgmime/README.webkit:
* xdgmime/src/xdgmimecache.c:
(cache_magic_matchlet_compare_to_data):

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ChangeLog (215552 => 215553)


--- trunk/Source/ThirdParty/ChangeLog	2017-04-20 05:26:51 UTC (rev 215552)
+++ trunk/Source/ThirdParty/ChangeLog	2017-04-20 06:26:59 UTC (rev 215553)
@@ -1,3 +1,14 @@
+2017-04-19  Michael Catanzaro  <[email protected]>
+
+        [GTK] ../../Source/ThirdParty/xdgmime/src/xdgmimecache.c:200:62: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
+        https://bugs.webkit.org/show_bug.cgi?id=171026
+
+        Reviewed by Carlos Garcia Campos.
+
+        * xdgmime/README.webkit:
+        * xdgmime/src/xdgmimecache.c:
+        (cache_magic_matchlet_compare_to_data):
+
 2017-03-24  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed. Fix the build after r214338.

Modified: trunk/Source/ThirdParty/xdgmime/README.webkit (215552 => 215553)


--- trunk/Source/ThirdParty/xdgmime/README.webkit	2017-04-20 05:26:51 UTC (rev 215552)
+++ trunk/Source/ThirdParty/xdgmime/README.webkit	2017-04-20 06:26:59 UTC (rev 215553)
@@ -11,6 +11,7 @@
 
  - Add xdg_mime_get_simple_globs
  - s/^#include <config.h>/#include "cmakeconfig.h"/g
+ - Fix invalid pointer arithmetic: https://bugs.webkit.org/show_bug.cgi?id=171026
 
 Changes included from GLib sources:
 

Modified: trunk/Source/ThirdParty/xdgmime/src/xdgmimecache.c (215552 => 215553)


--- trunk/Source/ThirdParty/xdgmime/src/xdgmimecache.c	2017-04-20 05:26:51 UTC (rev 215552)
+++ trunk/Source/ThirdParty/xdgmime/src/xdgmimecache.c	2017-04-20 06:26:59 UTC (rev 215553)
@@ -197,7 +197,7 @@
 	}
       else
 	{
-	  valid_matchlet = memcmp(cache->buffer + data_offset, data + i, data_length) == 0;
+	  valid_matchlet = memcmp(cache->buffer + data_offset, (unsigned char *)data + i, data_length) == 0;
 	}
 
       if (valid_matchlet)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to