Title: [216131] trunk/Source/WebCore
- Revision
- 216131
- Author
- za...@apple.com
- Date
- 2017-05-03 12:17:19 -0700 (Wed, 03 May 2017)
Log Message
RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=171608
Reviewed by Simon Fraser.
isTextField() is true for any generic single line text control.
* rendering/RenderObject.h:
(WebCore::RenderObject::isSearchField):
* rendering/RenderSearchField.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (216130 => 216131)
--- trunk/Source/WebCore/ChangeLog 2017-05-03 19:02:44 UTC (rev 216130)
+++ trunk/Source/WebCore/ChangeLog 2017-05-03 19:17:19 UTC (rev 216131)
@@ -1,3 +1,16 @@
+2017-05-03 Zalan Bujtas <za...@apple.com>
+
+ RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
+ https://bugs.webkit.org/show_bug.cgi?id=171608
+
+ Reviewed by Simon Fraser.
+
+ isTextField() is true for any generic single line text control.
+
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isSearchField):
+ * rendering/RenderSearchField.h:
+
2017-05-03 Frederic Wang <fw...@igalia.com>
Remove ScrollingCoordinator::supportsFixedPositionLayers()
Modified: trunk/Source/WebCore/rendering/RenderObject.h (216130 => 216131)
--- trunk/Source/WebCore/rendering/RenderObject.h 2017-05-03 19:02:44 UTC (rev 216130)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2017-05-03 19:17:19 UTC (rev 216131)
@@ -266,6 +266,7 @@
virtual bool isTextControl() const { return false; }
virtual bool isTextArea() const { return false; }
virtual bool isTextField() const { return false; }
+ virtual bool isSearchField() const { return false; }
virtual bool isTextControlInnerBlock() const { return false; }
virtual bool isVideo() const { return false; }
virtual bool isWidget() const { return false; }
Modified: trunk/Source/WebCore/rendering/RenderSearchField.h (216130 => 216131)
--- trunk/Source/WebCore/rendering/RenderSearchField.h 2017-05-03 19:02:44 UTC (rev 216130)
+++ trunk/Source/WebCore/rendering/RenderSearchField.h 2017-05-03 19:17:19 UTC (rev 216131)
@@ -45,6 +45,8 @@
void hidePopup();
private:
+ bool isSearchField() const final { return true; }
+
void willBeDestroyed() override;
void centerContainerIfNeeded(RenderBox*) const override;
LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const override;
@@ -92,4 +94,4 @@
} // namespace WebCore
-SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isTextField())
+SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isSearchField())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
