Title: [216132] trunk/Source/WebKit2
- Revision
- 216132
- Author
- [email protected]
- Date
- 2017-05-03 12:27:06 -0700 (Wed, 03 May 2017)
Log Message
Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge.
https://bugs.webkit.org/show_bug.cgi?id=171607
Reviewed by Andy Estes.
To test this fix we'd need the combination of an HTTPD inside API tests, so no test for now.
* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::hasOnlySecureContent): If the state is provisional, check the provisional URL instead.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216131 => 216132)
--- trunk/Source/WebKit2/ChangeLog 2017-05-03 19:17:19 UTC (rev 216131)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-03 19:27:06 UTC (rev 216132)
@@ -1,3 +1,15 @@
+2017-05-03 Brady Eidson <[email protected]>
+
+ Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge.
+ https://bugs.webkit.org/show_bug.cgi?id=171607
+
+ Reviewed by Andy Estes.
+
+ To test this fix we'd need the combination of an HTTPD inside API tests, so no test for now.
+
+ * UIProcess/PageLoadState.cpp:
+ (WebKit::PageLoadState::hasOnlySecureContent): If the state is provisional, check the provisional URL instead.
+
2017-05-03 Chris Dumez <[email protected]>
[WK2] Extend processDidCrash delegate to let the client know the reason for the crash
Modified: trunk/Source/WebKit2/UIProcess/PageLoadState.cpp (216131 => 216132)
--- trunk/Source/WebKit2/UIProcess/PageLoadState.cpp 2017-05-03 19:17:19 UTC (rev 216131)
+++ trunk/Source/WebKit2/UIProcess/PageLoadState.cpp 2017-05-03 19:27:06 UTC (rev 216132)
@@ -205,6 +205,9 @@
if (data.hasInsecureContent)
return false;
+ if (data.state == State::Provisional)
+ return WebCore::protocolIs(data.provisionalURL, "https");
+
return WebCore::protocolIs(data.url, "https");
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
