Title: [217688] trunk/Source/WebCore
- Revision
- 217688
- Author
- [email protected]
- Date
- 2017-06-01 16:16:30 -0700 (Thu, 01 Jun 2017)
Log Message
REGRESSION (r217296): Dragging a video only shows controls during drag event
https://bugs.webkit.org/show_bug.cgi?id=172837
rdar://problem/32434661
Reviewed by Zalan Bujtas.
r217296 changed RenderVideo::paintReplaced() from checking paintBehavior() flags on the FrameView
to paintInfo.paintBehavior flags. However, RenderLayer was stripping the PaintBehaviorFlattenCompositingLayers
flag from the paintInfo.paintBehavior flags, so fix that.
Not easily testable.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (217687 => 217688)
--- trunk/Source/WebCore/ChangeLog 2017-06-01 22:40:03 UTC (rev 217687)
+++ trunk/Source/WebCore/ChangeLog 2017-06-01 23:16:30 UTC (rev 217688)
@@ -1,5 +1,22 @@
2017-06-01 Simon Fraser <[email protected]>
+ REGRESSION (r217296): Dragging a video only shows controls during drag event
+ https://bugs.webkit.org/show_bug.cgi?id=172837
+ rdar://problem/32434661
+
+ Reviewed by Zalan Bujtas.
+
+ r217296 changed RenderVideo::paintReplaced() from checking paintBehavior() flags on the FrameView
+ to paintInfo.paintBehavior flags. However, RenderLayer was stripping the PaintBehaviorFlattenCompositingLayers
+ flag from the paintInfo.paintBehavior flags, so fix that.
+
+ Not easily testable.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintLayerContents):
+
+2017-06-01 Simon Fraser <[email protected]>
+
Remove the redundant selectionOnly argument from RenderLayer::paintForegroundForFragments()
https://bugs.webkit.org/show_bug.cgi?id=172835
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (217687 => 217688)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-06-01 22:40:03 UTC (rev 217687)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-06-01 23:16:30 UTC (rev 217688)
@@ -4384,6 +4384,9 @@
else if (localPaintFlags & PaintLayerPaintingRootBackgroundOnly)
paintBehavior |= PaintBehaviorRootBackgroundOnly;
+ if (paintingInfo.paintBehavior & PaintBehaviorFlattenCompositingLayers)
+ paintBehavior |= PaintBehaviorFlattenCompositingLayers;
+
if (paintingInfo.paintBehavior & PaintBehaviorSnapshotting)
paintBehavior |= PaintBehaviorSnapshotting;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
