Title: [217940] trunk/LayoutTests
- Revision
- 217940
- Author
- [email protected]
- Date
- 2017-06-08 11:54:43 -0700 (Thu, 08 Jun 2017)
Log Message
Rebaseline and enable media/modern-media-controls/forward-button
https://bugs.webkit.org/show_bug.cgi?id=173100
Reviewed by Dean Jackson.
Update the test to check an SVG asset now that we use those.
* media/modern-media-controls/forward-button/forward-button-expected.txt:
* media/modern-media-controls/forward-button/forward-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (217939 => 217940)
--- trunk/LayoutTests/ChangeLog 2017-06-08 18:53:53 UTC (rev 217939)
+++ trunk/LayoutTests/ChangeLog 2017-06-08 18:54:43 UTC (rev 217940)
@@ -1,5 +1,19 @@
2017-06-08 Antoine Quint <[email protected]>
+ Rebaseline and enable media/modern-media-controls/forward-button
+ https://bugs.webkit.org/show_bug.cgi?id=173100
+
+ Reviewed by Dean Jackson.
+
+ Update the test to check an SVG asset now that we use those.
+
+ * media/modern-media-controls/forward-button/forward-button-expected.txt:
+ * media/modern-media-controls/forward-button/forward-button.html:
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2017-06-08 Antoine Quint <[email protected]>
+
Layout Test media/modern-media-controls/button/button-icon-name.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=173099
Modified: trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button-expected.txt (217939 => 217940)
--- trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button-expected.txt 2017-06-08 18:53:53 UTC (rev 217939)
+++ trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button-expected.txt 2017-06-08 18:54:43 UTC (rev 217940)
@@ -4,10 +4,9 @@
PASS forwardButton.element.localName is "button"
-PASS forwardButton.element.classList.contains("icon") is true
PASS forwardButton.element.classList.contains("forward") is true
PASS forwardButton.iconName is Icons.Forward
-PASS forwardButton.element.style.webkitMaskImage.includes("macOS/forward@") became true
+PASS forwardButton.image.element.style.webkitMaskImage.includes("macOS/Forward.svg") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button.html (217939 => 217940)
--- trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button.html 2017-06-08 18:53:53 UTC (rev 217939)
+++ trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button.html 2017-06-08 18:54:43 UTC (rev 217940)
@@ -11,11 +11,10 @@
const forwardButton = new ForwardButton({ layoutTraits: LayoutTraits.macOS });
shouldBeEqualToString("forwardButton.element.localName", "button");
-shouldBeTrue('forwardButton.element.classList.contains("icon")');
shouldBeTrue('forwardButton.element.classList.contains("forward")');
shouldBe("forwardButton.iconName", "Icons.Forward");
-shouldBecomeEqual('forwardButton.element.style.webkitMaskImage.includes("macOS/forward@")', "true", finishMediaControlsTest);
+shouldBecomeEqual('forwardButton.image.element.style.webkitMaskImage.includes("macOS/Forward.svg")', "true", finishMediaControlsTest);
</script>
<script src=""
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (217939 => 217940)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-08 18:53:53 UTC (rev 217939)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-08 18:54:43 UTC (rev 217940)
@@ -62,6 +62,7 @@
media/modern-media-controls/button [ Pass ]
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/forward-button [ Pass ]
# AirPlay cannot be tested on iOS
webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (217939 => 217940)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-06-08 18:53:53 UTC (rev 217939)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-06-08 18:54:43 UTC (rev 217940)
@@ -1557,6 +1557,7 @@
media/modern-media-controls/button [ Pass ]
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/forward-button [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
media/modern-media-controls/volume-up-support [ Pass ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
