Title: [217941] trunk/LayoutTests
- Revision
- 217941
- Author
- [email protected]
- Date
- 2017-06-08 11:56:17 -0700 (Thu, 08 Jun 2017)
Log Message
Rebaseline and enable media/modern-media-controls/fullscreen-button
https://bugs.webkit.org/show_bug.cgi?id=173101
Reviewed by Dean Jackson.
Update the test to check an SVG asset now that we use those.
* media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt:
* media/modern-media-controls/fullscreen-button/fullscreen-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (217940 => 217941)
--- trunk/LayoutTests/ChangeLog 2017-06-08 18:54:43 UTC (rev 217940)
+++ trunk/LayoutTests/ChangeLog 2017-06-08 18:56:17 UTC (rev 217941)
@@ -1,5 +1,19 @@
2017-06-08 Antoine Quint <[email protected]>
+ Rebaseline and enable media/modern-media-controls/fullscreen-button
+ https://bugs.webkit.org/show_bug.cgi?id=173101
+
+ Reviewed by Dean Jackson.
+
+ Update the test to check an SVG asset now that we use those.
+
+ * media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt:
+ * media/modern-media-controls/fullscreen-button/fullscreen-button.html:
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2017-06-08 Antoine Quint <[email protected]>
+
Rebaseline and enable media/modern-media-controls/forward-button
https://bugs.webkit.org/show_bug.cgi?id=173100
Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt (217940 => 217941)
--- trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt 2017-06-08 18:54:43 UTC (rev 217940)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt 2017-06-08 18:56:17 UTC (rev 217941)
@@ -4,13 +4,12 @@
PASS enterFullscreenButton.element.localName is "button"
-PASS enterFullscreenButton.element.classList.contains("icon") is true
PASS enterFullscreenButton.element.classList.contains("fullscreen") is true
PASS enterFullscreenButton.iconName is Icons.EnterFullscreen
PASS exitFullscreenButton.iconName is Icons.ExitFullscreen
-PASS enterFullscreenButton.element.style.webkitMaskImage.includes("macOS/enter-fullscreen@") is true
-PASS iOSEnterFullscreenButton.element.style.webkitMaskImage.includes("iOS/enter-fullscreen@") is true
-PASS exitFullscreenButton.element.style.webkitMaskImage.includes("macOS/exit-fullscreen@") is true
+PASS enterFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/EnterFullscreen.svg") is true
+PASS iOSEnterFullscreenButton.image.element.style.webkitMaskImage.includes("iOS/EnterFullscreen.svg") is true
+PASS exitFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/ExitFullscreen.svg") is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button.html (217940 => 217941)
--- trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button.html 2017-06-08 18:54:43 UTC (rev 217940)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button.html 2017-06-08 18:56:17 UTC (rev 217941)
@@ -11,7 +11,6 @@
const enterFullscreenButton = new FullscreenButton({ layoutTraits: LayoutTraits.macOS });
shouldBeEqualToString("enterFullscreenButton.element.localName", "button");
-shouldBeTrue('enterFullscreenButton.element.classList.contains("icon")');
shouldBeTrue('enterFullscreenButton.element.classList.contains("fullscreen")');
shouldBe("enterFullscreenButton.iconName", "Icons.EnterFullscreen");
@@ -25,9 +24,9 @@
if ([enterFullscreenButton, iOSEnterFullscreenButton, exitFullscreenButton].some(button => button.width == 0))
return;
- shouldBeTrue('enterFullscreenButton.element.style.webkitMaskImage.includes("macOS/enter-fullscreen@")');
- shouldBeTrue('iOSEnterFullscreenButton.element.style.webkitMaskImage.includes("iOS/enter-fullscreen@")');
- shouldBeTrue('exitFullscreenButton.element.style.webkitMaskImage.includes("macOS/exit-fullscreen@")');
+ shouldBeTrue('enterFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/EnterFullscreen.svg")');
+ shouldBeTrue('iOSEnterFullscreenButton.image.element.style.webkitMaskImage.includes("iOS/EnterFullscreen.svg")');
+ shouldBeTrue('exitFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/ExitFullscreen.svg")');
finishMediaControlsTest();
};
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (217940 => 217941)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-08 18:54:43 UTC (rev 217940)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-08 18:56:17 UTC (rev 217941)
@@ -63,6 +63,7 @@
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
media/modern-media-controls/forward-button [ Pass ]
+media/modern-media-controls/fullscreen-button [ Pass ]
# AirPlay cannot be tested on iOS
webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (217940 => 217941)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-06-08 18:54:43 UTC (rev 217940)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-06-08 18:56:17 UTC (rev 217941)
@@ -1558,6 +1558,7 @@
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
media/modern-media-controls/forward-button [ Pass ]
+media/modern-media-controls/fullscreen-button [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
media/modern-media-controls/volume-up-support [ Pass ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
