Title: [217967] trunk/Source/WebKit2
- Revision
- 217967
- Author
- [email protected]
- Date
- 2017-06-09 01:05:32 -0700 (Fri, 09 Jun 2017)
Log Message
Crash in -[WKWebView _initializeWithConfiguration:]
https://bugs.webkit.org/show_bug.cgi?id=173126
Reviewed by Antti Koivisto.
Crash occurs when passing an autoreleased NSString into _setMediaContentTypesRequiringHardwareSupport.
The ivar should be a RetainPtr rather than a bare NSString *.
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _mediaContentTypesRequiringHardwareSupport]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217966 => 217967)
--- trunk/Source/WebKit2/ChangeLog 2017-06-09 08:03:47 UTC (rev 217966)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-09 08:05:32 UTC (rev 217967)
@@ -1,3 +1,16 @@
+2017-06-09 Jer Noble <[email protected]>
+
+ Crash in -[WKWebView _initializeWithConfiguration:]
+ https://bugs.webkit.org/show_bug.cgi?id=173126
+
+ Reviewed by Antti Koivisto.
+
+ Crash occurs when passing an autoreleased NSString into _setMediaContentTypesRequiringHardwareSupport.
+ The ivar should be a RetainPtr rather than a bare NSString *.
+
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ (-[WKWebViewConfiguration _mediaContentTypesRequiringHardwareSupport]):
+
2017-06-08 Carlos Garcia Campos <[email protected]>
[GTK] Use API::FormClient instead of the C API in WebKitFormClient
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (217966 => 217967)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-06-09 08:03:47 UTC (rev 217966)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2017-06-09 08:05:32 UTC (rev 217967)
@@ -138,7 +138,7 @@
BOOL _needsStorageAccessFromFileURLsQuirk;
NSString *_overrideContentSecurityPolicy;
- NSString *_mediaContentTypesRequiringHardwareSupport;
+ RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport;
}
- (instancetype)init
@@ -823,7 +823,7 @@
- (NSString *)_mediaContentTypesRequiringHardwareSupport
{
- return _mediaContentTypesRequiringHardwareSupport;
+ return _mediaContentTypesRequiringHardwareSupport.get();
}
- (void)_setMediaContentTypesRequiringHardwareSupport:(NSString *)mediaContentTypesRequiringHardwareSupport
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
