Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (217967 => 217968)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-09 08:21:17 UTC (rev 217968)
@@ -1,3 +1,12 @@
+2017-06-09 Daewoong Jang <[email protected]>
+
+ Reduce compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=172078
+
+ Reviewed by Yusuke Suzuki.
+
+ * runtime/IntlDateTimeFormat.h:
+
2017-06-08 Joseph Pecoraro <[email protected]>
[Cocoa] JSWrapperMap leaks for all JSContexts
Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h (217967 => 217968)
--- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.h 2017-06-09 08:21:17 UTC (rev 217968)
@@ -31,9 +31,7 @@
#include <unicode/udat.h>
#include <unicode/uvernum.h>
-#if U_ICU_VERSION_MAJOR_NUM >= 55
-#define JSC_ICU_HAS_UFIELDPOSITER 1
-#endif
+#define JSC_ICU_HAS_UFIELDPOSITER (U_ICU_VERSION_MAJOR_NUM >= 55)
namespace JSC {
Modified: trunk/Source/WebCore/ChangeLog (217967 => 217968)
--- trunk/Source/WebCore/ChangeLog 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/ChangeLog 2017-06-09 08:21:17 UTC (rev 217968)
@@ -1,3 +1,27 @@
+2017-06-09 Daewoong Jang <[email protected]>
+
+ Reduce compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=172078
+
+ Reviewed by Yusuke Suzuki.
+
+ * platform/network/curl/CookieJarCurl.cpp:
+ (WebCore::addMatchingCurlCookie):
+ (WebCore::getHostnamesWithCookies):
+ (WebCore::deleteCookiesForHostnames):
+ (WebCore::deleteCookiesForHostname): Deleted.
+ * platform/network/curl/CurlDownload.cpp:
+ (WebCore::CurlDownloadManager::downloadThread):
+ (WebCore::CurlDownload::didReceiveHeader):
+ * platform/network/curl/CurlDownload.h:
+ (WebCore::CurlDownloadListener::didReceiveDataOfLength):
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
+ (WebCore::ResourceHandle::platformLoadResourceSynchronously):
+ * platform/network/curl/SocketStreamHandleImplCurl.cpp:
+ (WebCore::createCopy):
+ (WebCore::SocketStreamHandleImpl::readData):
+
2017-06-09 Xabier Rodriguez Calvar <[email protected]>
[GStreamer][EME] Remove the legacy code that was not even official and is deprecated
Modified: trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp (217967 => 217968)
--- trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp 2017-06-09 08:21:17 UTC (rev 217968)
@@ -94,8 +94,6 @@
String cookieDomain;
readCurlCookieToken(cookie, cookieDomain);
- bool subDomain = false;
-
// HttpOnly cookie entries begin with "#HttpOnly_".
if (cookieDomain.startsWith("#HttpOnly_")) {
if (httponly)
@@ -332,12 +330,12 @@
// FIXME: Not yet implemented
}
-void getHostnamesWithCookies(const NetworkStorageSession&, HashSet<String>& hostnames)
+void getHostnamesWithCookies(const NetworkStorageSession&, HashSet<String>&)
{
// FIXME: Not yet implemented
}
-void deleteCookiesForHostname(const NetworkStorageSession&, const String& hostname)
+void deleteCookiesForHostnames(const NetworkStorageSession&, const Vector<String>&)
{
// FIXME: Not yet implemented
}
Modified: trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp (217967 => 217968)
--- trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp 2017-06-09 08:21:17 UTC (rev 217968)
@@ -204,6 +204,7 @@
CurlDownload* download = 0;
CURLcode err = curl_easy_getinfo(msg->easy_handle, CURLINFO_PRIVATE, &download);
+ UNUSED_PARAM(err);
if (msg->msg == CURLMSG_DONE) {
if (download) {
@@ -389,6 +390,7 @@
long httpCode = 0;
CURLcode err = curl_easy_getinfo(m_curlHandle, CURLINFO_RESPONSE_CODE, &httpCode);
+ UNUSED_PARAM(err);
if (httpCode >= 200 && httpCode < 300) {
URL url = ""
Modified: trunk/Source/WebCore/platform/network/curl/CurlDownload.h (217967 => 217968)
--- trunk/Source/WebCore/platform/network/curl/CurlDownload.h 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/platform/network/curl/CurlDownload.h 2017-06-09 08:21:17 UTC (rev 217968)
@@ -80,7 +80,7 @@
class CurlDownloadListener {
public:
virtual void didReceiveResponse() { }
- virtual void didReceiveDataOfLength(int size) { }
+ virtual void didReceiveDataOfLength(int) { }
virtual void didFinish() { }
virtual void didFail() { }
};
Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp (217967 => 217968)
--- trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2017-06-09 08:21:17 UTC (rev 217968)
@@ -46,10 +46,10 @@
public:
WebCoreSynchronousLoader();
- virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&);
- virtual void didReceiveData(ResourceHandle*, const char*, unsigned, int encodedDataLength);
- virtual void didFinishLoading(ResourceHandle*);
- virtual void didFail(ResourceHandle*, const ResourceError&);
+ void didReceiveResponse(ResourceHandle*, ResourceResponse&&) override;
+ void didReceiveData(ResourceHandle*, const char*, unsigned, int encodedDataLength) override;
+ void didFinishLoading(ResourceHandle*) override;
+ void didFail(ResourceHandle*, const ResourceError&) override;
ResourceResponse resourceResponse() const { return m_response; }
ResourceError resourceError() const { return m_error; }
@@ -65,9 +65,9 @@
{
}
-void WebCoreSynchronousLoader::didReceiveResponse(ResourceHandle*, const ResourceResponse& response)
+void WebCoreSynchronousLoader::didReceiveResponse(ResourceHandle*, ResourceResponse&& response)
{
- m_response = response;
+ m_response = WTFMove(response);
}
void WebCoreSynchronousLoader::didReceiveData(ResourceHandle*, const char* data, unsigned length, int)
@@ -163,7 +163,7 @@
return (!client() || client()->shouldUseCredentialStorage(this)) && firstRequest().url().protocolIsInHTTPFamily();
}
-void ResourceHandle::platformLoadResourceSynchronously(NetworkingContext* context, const ResourceRequest& request, StoredCredentials storedCredentials, ResourceError& error, ResourceResponse& response, Vector<char>& data)
+void ResourceHandle::platformLoadResourceSynchronously(NetworkingContext* context, const ResourceRequest& request, StoredCredentials, ResourceError& error, ResourceResponse& response, Vector<char>& data)
{
WebCoreSynchronousLoader syncLoader;
RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(context, request, &syncLoader, true, false));
Modified: trunk/Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp (217967 => 217968)
--- trunk/Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp 2017-06-09 08:05:32 UTC (rev 217967)
+++ trunk/Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp 2017-06-09 08:21:17 UTC (rev 217968)
@@ -49,7 +49,7 @@
std::unique_ptr<char[]> copy(new char[length]);
memcpy(copy.get(), data, length);
- return WTFMove(copy);
+ return copy;
}
SocketStreamHandleImpl::SocketStreamHandleImpl(const URL& url, SocketStreamHandleClient& client)
@@ -103,7 +103,7 @@
CURLcode ret = curl_easy_recv(curlHandle, data.get(), bufferSize, &bytesRead);
- if (ret == CURLE_OK && bytesRead >= 0) {
+ if (ret == CURLE_OK) {
m_mutexReceive.lock();
m_receiveData.append(SocketData { WTFMove(data), bytesRead });
m_mutexReceive.unlock();
