Title: [218072] trunk/LayoutTests
- Revision
- 218072
- Author
- [email protected]
- Date
- 2017-06-11 14:43:54 -0700 (Sun, 11 Jun 2017)
Log Message
Rebaseline media/modern-media-controls/mute-button
https://bugs.webkit.org/show_bug.cgi?id=173205
Reviewed by Jon Lee.
We now use SVG assets, so let the test reflect that.
* media/modern-media-controls/mute-button/mute-button-expected.txt:
* media/modern-media-controls/mute-button/mute-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218071 => 218072)
--- trunk/LayoutTests/ChangeLog 2017-06-11 21:40:31 UTC (rev 218071)
+++ trunk/LayoutTests/ChangeLog 2017-06-11 21:43:54 UTC (rev 218072)
@@ -1,5 +1,19 @@
2017-06-11 Antoine Quint <[email protected]>
+ Rebaseline media/modern-media-controls/mute-button
+ https://bugs.webkit.org/show_bug.cgi?id=173205
+
+ Reviewed by Jon Lee.
+
+ We now use SVG assets, so let the test reflect that.
+
+ * media/modern-media-controls/mute-button/mute-button-expected.txt:
+ * media/modern-media-controls/mute-button/mute-button.html:
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2017-06-11 Antoine Quint <[email protected]>
+
Remove media/modern-media-controls/macos-media-controls
https://bugs.webkit.org/show_bug.cgi?id=173204
Modified: trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt (218071 => 218072)
--- trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt 2017-06-11 21:40:31 UTC (rev 218071)
+++ trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt 2017-06-11 21:43:54 UTC (rev 218072)
@@ -4,14 +4,13 @@
PASS muteButton.element.localName is "button"
-PASS muteButton.element.classList.contains("icon") is true
PASS muteButton.element.classList.contains("mute") is true
PASS muteButton.iconName is Icons.Volume
PASS muteButton.muted is false
PASS mutedButton.muted is true
PASS mutedButton.iconName is Icons.VolumeMuted
-PASS muteButton.element.style.webkitMaskImage.includes("macOS/volume@") became true
-PASS mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@") became true
+PASS muteButton.image.element.style.webkitMaskImage.includes("macOS/VolumeHi.svg") became true
+PASS mutedButton.image.element.style.webkitMaskImage.includes("macOS/Mute.svg") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html (218071 => 218072)
--- trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html 2017-06-11 21:40:31 UTC (rev 218071)
+++ trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html 2017-06-11 21:43:54 UTC (rev 218072)
@@ -11,7 +11,6 @@
const muteButton = new MuteButton({ layoutTraits: LayoutTraits.macOS });
shouldBeEqualToString("muteButton.element.localName", "button");
-shouldBeTrue('muteButton.element.classList.contains("icon")');
shouldBeTrue('muteButton.element.classList.contains("mute")');
shouldBe("muteButton.iconName", "Icons.Volume");
shouldBeFalse("muteButton.muted");
@@ -21,8 +20,8 @@
shouldBeTrue("mutedButton.muted");
shouldBe("mutedButton.iconName", "Icons.VolumeMuted");
-shouldBecomeEqual('muteButton.element.style.webkitMaskImage.includes("macOS/volume@")', "true", () => {
- shouldBecomeEqual('mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@")', "true", finishJSTest);
+shouldBecomeEqual('muteButton.image.element.style.webkitMaskImage.includes("macOS/VolumeHi.svg")', "true", () => {
+ shouldBecomeEqual('mutedButton.image.element.style.webkitMaskImage.includes("macOS/Mute.svg")', "true", finishJSTest);
});
</script>
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (218071 => 218072)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-11 21:40:31 UTC (rev 218071)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-11 21:43:54 UTC (rev 218072)
@@ -68,6 +68,7 @@
media/modern-media-controls/invalid-placard [ Pass ]
media/modern-media-controls/layout-item [ Pass ]
media/modern-media-controls/layout-node [ Pass ]
+media/modern-media-controls/mute-button [ Pass ]
# AirPlay cannot be tested on iOS
webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (218071 => 218072)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-06-11 21:40:31 UTC (rev 218071)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-06-11 21:43:54 UTC (rev 218072)
@@ -1563,6 +1563,7 @@
media/modern-media-controls/layout-node [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
+media/modern-media-controls/mute-button [ Pass ]
media/modern-media-controls/volume-up-support [ Pass ]
# These tests are iOS-specific
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
