Title: [218073] trunk/LayoutTests
- Revision
- 218073
- Author
- [email protected]
- Date
- 2017-06-11 14:45:38 -0700 (Sun, 11 Jun 2017)
Log Message
Rebaseline media/modern-media-controls/pip-button.
https://bugs.webkit.org/show_bug.cgi?id=173206
Reviewed by Jon Lee.
Use SVG assets.
* media/modern-media-controls/pip-button/pip-button-expected.txt:
* media/modern-media-controls/pip-button/pip-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218072 => 218073)
--- trunk/LayoutTests/ChangeLog 2017-06-11 21:43:54 UTC (rev 218072)
+++ trunk/LayoutTests/ChangeLog 2017-06-11 21:45:38 UTC (rev 218073)
@@ -1,5 +1,19 @@
2017-06-11 Antoine Quint <[email protected]>
+ Rebaseline media/modern-media-controls/pip-button.
+ https://bugs.webkit.org/show_bug.cgi?id=173206
+
+ Reviewed by Jon Lee.
+
+ Use SVG assets.
+
+ * media/modern-media-controls/pip-button/pip-button-expected.txt:
+ * media/modern-media-controls/pip-button/pip-button.html:
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2017-06-11 Antoine Quint <[email protected]>
+
Rebaseline media/modern-media-controls/mute-button
https://bugs.webkit.org/show_bug.cgi?id=173205
Modified: trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt (218072 => 218073)
--- trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt 2017-06-11 21:43:54 UTC (rev 218072)
+++ trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button-expected.txt 2017-06-11 21:45:38 UTC (rev 218073)
@@ -4,11 +4,10 @@
PASS pipButton.element.localName is "button"
-PASS pipButton.element.classList.contains("icon") is true
PASS pipButton.element.classList.contains("pip") is true
PASS pipButton.iconName is Icons.EnterPiP
-PASS pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@") became true
-PASS iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@") became true
+PASS pipButton.image.element.style.webkitMaskImage.includes("macOS/PipIn.svg") became true
+PASS iOSPiPButton.image.element.style.webkitMaskImage.includes("iOS/PipIn.svg") became true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html (218072 => 218073)
--- trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html 2017-06-11 21:43:54 UTC (rev 218072)
+++ trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html 2017-06-11 21:45:38 UTC (rev 218073)
@@ -11,14 +11,13 @@
const pipButton = new PiPButton({ layoutTraits: LayoutTraits.macOS });
shouldBeEqualToString("pipButton.element.localName", "button");
-shouldBeTrue('pipButton.element.classList.contains("icon")');
shouldBeTrue('pipButton.element.classList.contains("pip")');
shouldBe("pipButton.iconName", "Icons.EnterPiP");
const iOSPiPButton = new PiPButton({ layoutTraits: LayoutTraits.iOS });
-shouldBecomeEqual('pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@")', "true", () => {
- shouldBecomeEqual('iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@")', "true", () => {
+shouldBecomeEqual('pipButton.image.element.style.webkitMaskImage.includes("macOS/PipIn.svg")', "true", () => {
+ shouldBecomeEqual('iOSPiPButton.image.element.style.webkitMaskImage.includes("iOS/PipIn.svg")', "true", () => {
debug("");
finishJSTest();
});
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (218072 => 218073)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-11 21:43:54 UTC (rev 218072)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-11 21:45:38 UTC (rev 218073)
@@ -69,6 +69,7 @@
media/modern-media-controls/layout-item [ Pass ]
media/modern-media-controls/layout-node [ Pass ]
media/modern-media-controls/mute-button [ Pass ]
+media/modern-media-controls/pip-button [ Pass ]
# AirPlay cannot be tested on iOS
webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (218072 => 218073)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-06-11 21:43:54 UTC (rev 218072)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-06-11 21:45:38 UTC (rev 218073)
@@ -1564,6 +1564,7 @@
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
media/modern-media-controls/mute-button [ Pass ]
+media/modern-media-controls/pip-button [ Pass ]
media/modern-media-controls/volume-up-support [ Pass ]
# These tests are iOS-specific
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
