Title: [222123] trunk/Websites/perf.webkit.org
- Revision
- 222123
- Author
- [email protected]
- Date
- 2017-09-15 18:11:27 -0700 (Fri, 15 Sep 2017)
Log Message
Should not mark a platform as missing in summary page if all expecting metrics are exlucded.
https://bugs.webkit.org/show_bug.cgi?id=176970
Reviewed by Ryosuke Niwa.
In summary page, if all metrics for a test are excluded in excludedConfigurations for a platform, this platform should not be marked as missing.
* public/v3/pages/summary-page.js:
(SummaryPageConfigurationGroup):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (222122 => 222123)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-09-16 00:05:42 UTC (rev 222122)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-09-16 01:11:27 UTC (rev 222123)
@@ -1,3 +1,15 @@
+2017-09-15 Dewei Zhu <[email protected]>
+
+ Should not mark a platform as missing in summary page if all expecting metrics are exlucded.
+ https://bugs.webkit.org/show_bug.cgi?id=176970
+
+ Reviewed by Ryosuke Niwa.
+
+ In summary page, if all metrics for a test are excluded in excludedConfigurations for a platform, this platform should not be marked as missing.
+
+ * public/v3/pages/summary-page.js:
+ (SummaryPageConfigurationGroup):
+
2017-09-11 Ryosuke Niwa <[email protected]>
Analysis task page shows an empty results for an irrelevant top-level test
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js (222122 => 222123)
--- trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2017-09-16 00:05:42 UTC (rev 222122)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2017-09-16 01:11:27 UTC (rev 222123)
@@ -259,16 +259,19 @@
this._isFetching = false;
this._smallerIsBetter = metrics.length ? metrics[0].isSmallerBetter() : null;
- for (var platform of platforms) {
+ for (const platform of platforms) {
console.assert(platform instanceof Platform);
- var foundInSomeMetric = false;
- for (var metric of metrics) {
+ let foundInSomeMetric = false;
+ let excludedMerticCount = 0;
+ for (const metric of metrics) {
console.assert(metric instanceof Metric);
console.assert(this._smallerIsBetter == metric.isSmallerBetter());
metric.isSmallerBetter();
- if (excludedConfigurations && platform.id() in excludedConfigurations && excludedConfigurations[platform.id()].includes(+metric.id()))
+ if (excludedConfigurations && platform.id() in excludedConfigurations && excludedConfigurations[platform.id()].includes(+metric.id())) {
+ excludedMerticCount += 1;
continue;
+ }
if (!platform.hasMetric(metric))
continue;
foundInSomeMetric = true;
@@ -275,7 +278,7 @@
this._measurementSets.push(MeasurementSet.findSet(platform.id(), metric.id(), platform.lastModified(metric)));
this._configurationList.push([platform.id(), metric.id()]);
}
- if (!foundInSomeMetric)
+ if (!foundInSomeMetric && excludedMerticCount < metrics.length)
this._missingPlatforms.add(platform);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
