Title: [222125] trunk/Source/WebCore
- Revision
- 222125
- Author
- [email protected]
- Date
- 2017-09-15 19:26:44 -0700 (Fri, 15 Sep 2017)
Log Message
Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer()
https://bugs.webkit.org/show_bug.cgi?id=177028
Patch by Said Abou-Hallawa <[email protected]> on 2017-09-15
Reviewed by Tim Horton.
String::format() is a bigger hammer for what we need to do in this function.
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222124 => 222125)
--- trunk/Source/WebCore/ChangeLog 2017-09-16 02:12:17 UTC (rev 222124)
+++ trunk/Source/WebCore/ChangeLog 2017-09-16 02:26:44 UTC (rev 222125)
@@ -1,3 +1,14 @@
+2017-09-15 Said Abou-Hallawa <[email protected]>
+
+ Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer()
+ https://bugs.webkit.org/show_bug.cgi?id=177028
+
+ Reviewed by Tim Horton.
+
+ String::format() is a bigger hammer for what we need to do in this function.
+
+ * platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
+
2017-09-15 Ryosuke Niwa <[email protected]>
iOS: Use blob URL instead of a WebKit fake URL when pasting an image
Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm (222124 => 222125)
--- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm 2017-09-16 02:12:17 UTC (rev 222124)
+++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm 2017-09-16 02:26:44 UTC (rev 222125)
@@ -68,9 +68,10 @@
BEGIN_BLOCK_OBJC_EXCEPTIONS
RetainPtr<NSMutableArray> array = adoptNS([[NSMutableArray alloc] init]);
-
+ static NeverDestroyed<String> filterNamePrefix(MAKE_STATIC_STRING_IMPL("filter_"));
+
for (unsigned i = 0; i < filters.size(); ++i) {
- String filterName = String::format("filter_%d", i);
+ String filterName = filterNamePrefix.get() + String::number(i);
const FilterOperation& filterOperation = *filters.at(i);
switch (filterOperation.type()) {
case FilterOperation::DEFAULT:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
