Title: [222126] trunk/Source/WebCore
- Revision
- 222126
- Author
- [email protected]
- Date
- 2017-09-15 23:39:15 -0700 (Fri, 15 Sep 2017)
Log Message
[Harbuzz] Test fast/text/international/harfbuzz-runs-with-no-glyph.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=177005
Reviewed by Michael Catanzaro.
Fixes: fast/text/international/harfbuzz-runs-with-no-glyph.html
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset): Return early if there aren't glyphs.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222125 => 222126)
--- trunk/Source/WebCore/ChangeLog 2017-09-16 02:26:44 UTC (rev 222125)
+++ trunk/Source/WebCore/ChangeLog 2017-09-16 06:39:15 UTC (rev 222126)
@@ -1,3 +1,15 @@
+2017-09-15 Carlos Garcia Campos <[email protected]>
+
+ [Harbuzz] Test fast/text/international/harfbuzz-runs-with-no-glyph.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=177005
+
+ Reviewed by Michael Catanzaro.
+
+ Fixes: fast/text/international/harfbuzz-runs-with-no-glyph.html
+
+ * platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
+ (WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset): Return early if there aren't glyphs.
+
2017-09-15 Said Abou-Hallawa <[email protected]>
Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer()
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (222125 => 222126)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp 2017-09-16 02:26:44 UTC (rev 222125)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp 2017-09-16 06:39:15 UTC (rev 222126)
@@ -132,6 +132,9 @@
float HarfBuzzShaper::HarfBuzzRun::xPositionForOffset(unsigned offset)
{
ASSERT(offset < m_numCharacters);
+ if (!m_numGlyphs)
+ return 0;
+
unsigned glyphIndex = 0;
float position = 0;
if (rtl()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
