Title: [222744] trunk/Source/_javascript_Core
Revision
222744
Author
[email protected]
Date
2017-10-02 14:40:19 -0700 (Mon, 02 Oct 2017)

Log Message

Unreviewed. Add missing exception check for the custom-get-set-inline-caching-one-level-up-proto-chain.js
test that I added. It uncovered a pre-existing missing exception check.

* runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (222743 => 222744)


--- trunk/Source/_javascript_Core/ChangeLog	2017-10-02 21:31:46 UTC (rev 222743)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-02 21:40:19 UTC (rev 222744)
@@ -1,3 +1,11 @@
+2017-10-02  Saam Barati  <[email protected]>
+
+        Unreviewed. Add missing exception check for the custom-get-set-inline-caching-one-level-up-proto-chain.js
+        test that I added. It uncovered a pre-existing missing exception check.
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::putInlineSlow):
+
 2017-10-02  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Include Beacon and Ping requests in Network tab

Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (222743 => 222744)


--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-10-02 21:31:46 UTC (rev 222743)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2017-10-02 21:40:19 UTC (rev 222744)
@@ -784,6 +784,7 @@
             }
             if (gs.isCustomGetterSetter()) {
                 bool result = callCustomSetter(exec, gs, attributes & PropertyAttribute::CustomAccessor, obj, slot.thisValue(), value);
+                RETURN_IF_EXCEPTION(scope, false);
                 if (attributes & PropertyAttribute::CustomAccessor)
                     slot.setCustomAccessor(obj, jsCast<CustomGetterSetter*>(gs.asCell())->setter());
                 else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to