Title: [222745] trunk/Source/WebCore
- Revision
- 222745
- Author
- [email protected]
- Date
- 2017-10-02 14:42:19 -0700 (Mon, 02 Oct 2017)
Log Message
No need to truncate text after calling InlineTextBox::text()
https://bugs.webkit.org/show_bug.cgi?id=177748
Reviewed by Zalan Bujtas.
Following r222670 it is no longer necessary to explicitly truncate the text run length
as InlineTextBox::text() returns a text run with respect to the truncation of the text box.
No functionality changed. So, no new tests.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (222744 => 222745)
--- trunk/Source/WebCore/ChangeLog 2017-10-02 21:40:19 UTC (rev 222744)
+++ trunk/Source/WebCore/ChangeLog 2017-10-02 21:42:19 UTC (rev 222745)
@@ -1,3 +1,18 @@
+2017-10-02 Daniel Bates <[email protected]>
+
+ No need to truncate text after calling InlineTextBox::text()
+ https://bugs.webkit.org/show_bug.cgi?id=177748
+
+ Reviewed by Zalan Bujtas.
+
+ Following r222670 it is no longer necessary to explicitly truncate the text run length
+ as InlineTextBox::text() returns a text run with respect to the truncation of the text box.
+
+ No functionality changed. So, no new tests.
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+
2017-10-02 Antti Koivisto <[email protected]>
Add makeWeakPtr variant that takes pointer
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (222744 => 222745)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2017-10-02 21:40:19 UTC (rev 222744)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2017-10-02 21:42:19 UTC (rev 222745)
@@ -514,7 +514,6 @@
if (m_truncation != cNoTruncation) {
selectionStart = std::min(selectionStart, static_cast<unsigned>(m_truncation));
selectionEnd = std::min(selectionEnd, static_cast<unsigned>(m_truncation));
- length = m_truncation;
}
float emphasisMarkOffset = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
